12714 enable locally fair flag #12722

Open
ashmanda-cs opened 5:34pm on September 17, 2026 wants to merge 15 Δ into iqss/dataverse develop from
12714-enable-locally-FAIR-flag

Pull Request Overview

  • Opened on September 17, 2026
  • Status Open
  • Commit count 5 with first commit September 17, 2026

Total Delta

15 Total Diff Delta

Open Days

Open 2 weekdays

Test Delta

0 Diff Delta in Test Files
Breakdown by Phase

How long has this pull request spent in each phase of its lifecycle?

Fraction of total time Business days Phase
N/A 1.2 days Issue creation to work beginning
 
0.0 days Authoring 4 commits before pull request opened for review
 
0.0 days Awaiting first review
 
1.0 day Revising work with 1 commit in response to 1 review that left 3 comments

Total time for pull request still awaiting merge: 1.0 business day

Author avatar

12714 enable locally fair flag

What this PR does / why we need it:
Enables Locally FAIR during the docker build step and suppresses the locally FAIR JSF frontend test

Which issue(s) this PR closes:
- Closes #12714

Special notes for your reviewer:
N/A

Suggestions on how to test this:
Both the Container Integration Tests and JSF Frontend Tests MUST pass.

Does this PR introduce a user interface change? If mockups are available, please link/include them here:
N/A

Is there a release notes update needed for this change?:
N/A

Additional documentation:
N/A

Overview of the Feature Request Neither of the testing workflows currently have locally FAIR enabled. The new test suite has a test for locally FAIR and due to the lack of the flag, the test seems to be failing.

What kind of user is the feature intended for? (Example users roles: API User, Curator, Depositor, Guest, Superuser, Sysadmin) Developers

What inspired the request? Failing tests

What existing behavior do you want changed? Add a flag to both workflows during the "Start Dataverse Stack" step: "-Ddataverse.feature.allow-locally-fair-data=true"

Any brand new behavior do you want to add to Dataverse? N/A

Any open or closed issues related to this feature request? N/A

Are you thinking about creating a pull request for this feature?
I will make a PR myself if the team thinks this is something that should be needed.

Comments Threads Pending Resolution

ljharb reviewed on September 17, 2026
ljharb left a comment

### 🟡 Changes recommended

The JSF workflow appears to disable/suppress Locally FAIR frontend coverage via `LOCALLY_FAIR_ENABLED: "false"`, which undermines validating the newly enabled feature in CI.

*Get a fresh assessment by requesting another Copilot review.*

Pull request overview

This PR updates GitHub Actions workflows to enable the Dataverse “Locally FAIR” feature flag when starting the Docker-based stack during CI, aligning the CI environment with Locally FAIR expectations.

**Changes:**
- Add `-Ddataverse.feature.allow-locally-fair-data=true` to the “Start Dataverse stack” Maven command in both workflows.
- Add `LOCALLY_FAIR_ENABLED` env var to the JSF/Playwright test step (currently set to `"false"`).

File summaries

| File | Description |
| ---- | ----------- |
| .github/workflows/dataverse_jsf_tests.yml | Enables Locally FAIR feature flag at stack start; adds an env var affecting Locally FAIR-related frontend tests. |
| .github/workflows/container_integration_tests.yml | Enables Locally FAIR feature flag at stack start for container integration tests. |

Review details

- **Files reviewed:** 2/2 changed files
- **Comments generated:** 1
- **Review effort level:** Lite

---

💡 Add a `code-review` agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Resolved Comment Threads

ljharb reviewed on September 17, 2026
ljharb left a comment

### 🟡 Changes recommended

The JSF workflow appears to disable/suppress Locally FAIR frontend coverage via `LOCALLY_FAIR_ENABLED: "false"`, which undermines validating the newly enabled feature in CI.

*Get a fresh assessment by requesting another Copilot review.*

Pull request overview

This PR updates GitHub Actions workflows to enable the Dataverse “Locally FAIR” feature flag when starting the Docker-based stack during CI, aligning the CI environment with Locally FAIR expectations.

**Changes:**
- Add `-Ddataverse.feature.allow-locally-fair-data=true` to the “Start Dataverse stack” Maven command in both workflows.
- Add `LOCALLY_FAIR_ENABLED` env var to the JSF/Playwright test step (currently set to `"false"`).

File summaries

| File | Description |
| ---- | ----------- |
| .github/workflows/dataverse_jsf_tests.yml | Enables Locally FAIR feature flag at stack start; adds an env var affecting Locally FAIR-related frontend tests. |
| .github/workflows/container_integration_tests.yml | Enables Locally FAIR feature flag at stack start for container integration tests. |

Review details

- **Files reviewed:** 2/2 changed files
- **Comments generated:** 1
- **Review effort level:** Lite

---

💡 Add a `code-review` agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.