Pull request #12720 quality checks

Code files and functions touched by this pull request are analyzed below.

Quality targets

How does this pull request compare to chosen code quality targets? Read more about code quality targets.

Target name	Target value	This PR
Maximum Diff Delta per PR	500	2624
Maximum comment count per PR	10	5
Pull request maximum business days between activity	3	2
Pull request maximum business days open	5	2

Coupled files

Are there any files from this commit that are always committed alongside another file? This often suggests that there exists code coupling to potentially remove. Read more about code coupling

Committed together %	Code file Coupled code file	Commits in PR with both
100	src/test/java/edu/harvard/iq/dataverse/feedback/FeedbackUtilTest.java src/test/java/edu/harvard/iq/dataverse/api/DataversesIT.java	1
100	src/main/java/edu/harvard/iq/dataverse/DataverseLinkingServiceBean.java src/main/java/edu/harvard/iq/dataverse/DataverseServiceBean.java	1
100	src/main/java/edu/harvard/iq/dataverse/DataverseLinkingServiceBean.java src/main/java/edu/harvard/iq/dataverse/search/savedsearch/SavedSearchServiceBean.java	1
100	src/main/java/edu/harvard/iq/dataverse/DataverseLinkingServiceBean.java src/main/java/edu/harvard/iq/dataverse/api/Dataverses.java	1
100	src/main/java/edu/harvard/iq/dataverse/mydata/RoleTagRetriever.java src/main/java/edu/harvard/iq/dataverse/DvObjectServiceBean.java	1
100	src/main/java/edu/harvard/iq/dataverse/engine/command/impl/DeleteDataverseLinkingDataverseCommand.java src/main/java/edu/harvard/iq/dataverse/engine/command/impl/LinkDataverseCommand.java	1
100	src/test/java/edu/harvard/iq/dataverse/api/auth/SignedUrlAuthMechanismTest.java src/main/java/edu/harvard/iq/dataverse/api/auth/SignedUrlAuthMechanism.java	3
100	src/test/java/edu/harvard/iq/dataverse/api/auth/doubles/SignedUrlUriInfoTestFake.java src/main/java/edu/harvard/iq/dataverse/api/Admin.java	1
100	src/test/java/edu/harvard/iq/dataverse/api/auth/doubles/SignedUrlUriInfoTestFake.java src/main/java/edu/harvard/iq/dataverse/api/auth/SignedUrlAuthMechanism.java	1
100	src/test/java/edu/harvard/iq/dataverse/api/auth/doubles/SignedUrlUriInfoTestFake.java src/test/java/edu/harvard/iq/dataverse/api/auth/SignedUrlAuthMechanismTest.java	2
100	.github/workflows/container_app_pr.yml .github/workflows/container_app_push.yml	1
100	.github/workflows/spi_release.yml .github/workflows/container_app_pr.yml	1
100	.github/workflows/maven_cache_management.yml .github/workflows/maven_unit_test.yml	3
100	.github/workflows/maven_cache_management.yml .github/workflows/container_app_pr.yml	3
100	src/test/java/edu/harvard/iq/dataverse/util/signing/FixedSigningSecret.java src/test/java/edu/harvard/iq/dataverse/util/signing/ApiSigningSecretServiceBeanTest.java	3
100	src/test/java/edu/harvard/iq/dataverse/util/signing/FixedSigningSecret.java src/main/java/edu/harvard/iq/dataverse/util/signing/ApiSigningSecretServiceBean.java	3
100	src/test/java/edu/harvard/iq/dataverse/util/signing/FixedSigningSecret.java src/main/java/edu/harvard/iq/dataverse/api/Admin.java	3
100	src/test/java/edu/harvard/iq/dataverse/settings/SettingsServiceBeanTest.java src/main/java/edu/harvard/iq/dataverse/settings/SettingsServiceBean.java	3
100	src/test/java/edu/harvard/iq/dataverse/util/signing/ApiSigningSecretServiceBeanTest.java src/main/java/edu/harvard/iq/dataverse/util/signing/ApiSigningSecretServiceBean.java	4
100	.github/workflows/maven_cache_management.yml .github/workflows/deploy_beta_testing.yml	3
100	.github/workflows/maven_cache_management.yml .github/workflows/spi_release.yml	1
94	src/main/java/edu/harvard/iq/dataverse/api/auth/SignedUrlAuthMechanism.java src/test/java/edu/harvard/iq/dataverse/api/auth/SignedUrlAuthMechanismTest.java	3
88	src/test/java/edu/harvard/iq/dataverse/api/auth/SignedUrlAuthMechanismTest.java src/test/java/edu/harvard/iq/dataverse/api/auth/doubles/SignedUrlUriInfoTestFake.java	2
88	src/test/java/edu/harvard/iq/dataverse/feedback/FeedbackUtilTest.java src/test/java/edu/harvard/iq/dataverse/util/json/JsonParserTest.java	1
87	.github/workflows/generate_war_file.yml .github/workflows/deploy_to_internal.yml	3
85	src/test/java/edu/harvard/iq/dataverse/util/UrlSignerUtilTest.java src/main/java/edu/harvard/iq/dataverse/util/UrlSignerUtil.java	1
80	src/main/java/edu/harvard/iq/dataverse/util/signing/ApiSigningSecretServiceBean.java src/test/java/edu/harvard/iq/dataverse/util/signing/ApiSigningSecretServiceBeanTest.java	4
80	src/main/java/edu/harvard/iq/dataverse/util/signing/ApiSigningSecretServiceBean.java doc/release-notes/fix-url-signing-special-characters.md	4
75	src/test/java/edu/harvard/iq/dataverse/util/signing/ApiSigningSecretServiceBeanTest.java src/main/java/edu/harvard/iq/dataverse/api/Admin.java	3
75	src/test/java/edu/harvard/iq/dataverse/util/signing/ApiSigningSecretServiceBeanTest.java doc/release-notes/fix-url-signing-special-characters.md	3
75	src/test/java/edu/harvard/iq/dataverse/util/signing/ApiSigningSecretServiceBeanTest.java src/test/java/edu/harvard/iq/dataverse/util/signing/FixedSigningSecret.java	3
75	src/test/java/edu/harvard/iq/dataverse/api/AdminSettingsSecretTest.java src/main/java/edu/harvard/iq/dataverse/settings/SettingsServiceBean.java	3
75	src/test/java/edu/harvard/iq/dataverse/api/AdminSettingsSecretTest.java src/main/java/edu/harvard/iq/dataverse/api/Admin.java	3
73	src/main/java/edu/harvard/iq/dataverse/externaltools/ExternalToolHandler.java src/main/java/edu/harvard/iq/dataverse/api/Admin.java	1
73	.github/workflows/spi_release.yml .github/workflows/maven_unit_test.yml	1
71	src/main/java/edu/harvard/iq/dataverse/ManageFilePermissionsPage.java src/main/java/edu/harvard/iq/dataverse/api/Access.java	2
70	src/test/java/edu/harvard/iq/dataverse/api/auth/SignedUrlAuthMechanismTest.java src/main/java/edu/harvard/iq/dataverse/api/Admin.java	2

Biggest files changes in pull request

Estimated line counts are shown. Values may change once change summary has finished building.

Path	View whole file	Lines removed	Lines added	Final line count
src/main/java/edu/harvard/iq/dataverse/api/Access.java	Before After	74	51	---
src/main/java/edu/harvard/iq/dataverse/export/DDIExportServiceBean.java	Before After	71	13	---
src/main/java/edu/harvard/iq/dataverse/util/UrlSignerUtil.java	Before After	110	5	---
src/test/java/edu/harvard/iq/dataverse/api/auth/SignedUrlAuthMechanismTest.java	Before After	15	70	---
src/main/java/edu/harvard/iq/dataverse/DataversePage.java	Before After	23	27	---
src/test/java/edu/harvard/iq/dataverse/api/LinkIT.java	Before After	35	9	---
src/test/java/edu/harvard/iq/dataverse/externaltools/ExternalToolHandlerTest.java	Before After	3	68	---
src/main/java/edu/harvard/iq/dataverse/util/signing/ApiSigningSecretServiceBean.java	Before After	9	61	---
src/main/java/edu/harvard/iq/dataverse/api/Admin.java	Before After	13	15	---
src/test/java/edu/harvard/iq/dataverse/api/AdminRequestSignedUrlTest.java	Before After	0	102	---
src/main/java/edu/harvard/iq/dataverse/api/auth/SignedUrlAuthMechanism.java	Before After	10	30	---
src/test/java/edu/harvard/iq/dataverse/util/MarkupCheckerTest.java	Before After	47	41	---
src/test/java/edu/harvard/iq/dataverse/util/UrlSignerUtilTest.java	Before After	67	1	---
src/main/java/edu/harvard/iq/dataverse/mydata/MyDataFinder.java	Before After	5	2	---
src/test/java/edu/harvard/iq/dataverse/util/signing/ApiSigningSecretServiceBeanTest.java	Before After	17	62	---
src/test/java/edu/harvard/iq/dataverse/util/MarkupCheckerUtil.java	Before After	0	97	---
src/main/webapp/resources/js/dv_rebind_bootstrap_ui.js	Before After	0	50	---
src/test/java/edu/harvard/iq/dataverse/PermissionsHistorySignedUrlTest.java	Before After	0	86	---
modules/dataverse-parent/pom.xml	Before After	0	15	---
src/main/java/edu/harvard/iq/dataverse/engine/command/impl/UpdateDvObjectPIDMetadataCommand.java	Before After	3	0	---
src/main/java/edu/harvard/iq/dataverse/mydata/RoleTagRetriever.java	Before After	3	1	---
src/main/java/edu/harvard/iq/dataverse/util/URLTokenUtil.java	Before After	1	25	---
src/main/java/edu/harvard/iq/dataverse/ManageFilePermissionsPage.java	Before After	3	2	---
src/main/java/edu/harvard/iq/dataverse/ManagePermissionsPage.java	Before After	3	2	---
doc/release-notes/6.12-release-notes.md	Before After	3	287	---
src/main/java/edu/harvard/iq/dataverse/DataverseLinkingServiceBean.java	Before After	0	0	---
src/main/java/edu/harvard/iq/dataverse/GuestbookResponseServiceBean.java	Before After	0	0	---
src/main/java/edu/harvard/iq/dataverse/dataaccess/S3AccessIO.java	Before After	1	2	---
src/test/java/edu/harvard/iq/dataverse/api/auth/doubles/SignedUrlUriInfoTestFake.java	Before After	0	8	---
src/main/java/edu/harvard/iq/dataverse/DataverseServiceBean.java	Before After	7	2	---
src/main/java/edu/harvard/iq/dataverse/api/imports/ImportGenericServiceBean.java	Before After	16	0	---
pom.xml	Before After	3	3	---
doc/release-notes/12493-payara7-2026.7plus.md	Before After	112	45	---
src/test/java/edu/harvard/iq/dataverse/feedback/FeedbackUtilTest.java	Before After	16	0	---
src/test/java/edu/harvard/iq/dataverse/util/signing/FixedSigningSecret.java	Before After	1	15	---
src/main/java/edu/harvard/iq/dataverse/engine/command/impl/DeleteDataverseLinkingDataverseCommand.java	Before After	0	4	---
src/test/java/edu/harvard/iq/dataverse/api/DatasetsIT.java	Before After	2	0	---
src/test/java/edu/harvard/iq/dataverse/api/DataversesIT.java	Before After	14	0	---
src/main/java/edu/harvard/iq/dataverse/GuestbookResponse.java	Before After	0	4	---
docker/compose/demo/compose.yml	Before After	3	0	---
src/main/java/edu/harvard/iq/dataverse/UserServiceBean.java	Before After	0	0	---
src/main/java/edu/harvard/iq/dataverse/engine/command/impl/LinkDataverseCommand.java	Before After	0	4	---
src/main/java/edu/harvard/iq/dataverse/openapi/DataverseOpenApiFilter.java	Before After	0	0	---
conf/keycloak/docker-compose-dev.yml	Before After	1	0	---
doc/release-notes/12433-NPE-draft-prefiew	Before After	1	0	---
docker-compose-dev.yml	Before After	1	0	---
doc/release-notes/fix-url-signing-special-characters.md	Before After	60	2	---
src/main/java/edu/harvard/iq/dataverse/TemplateServiceBean.java	Before After	0	18	---
src/test/java/edu/harvard/iq/dataverse/util/JhoveFileTypeTest.java	Before After	4	0	---
src/main/java/edu/harvard/iq/dataverse/search/savedsearch/SavedSearchServiceBean.java	Before After	0	0	---
src/main/java/edu/harvard/iq/dataverse/globus/GlobusServiceBean.java	Before After	3	2	---
src/main/java/edu/harvard/iq/dataverse/DataFileServiceBean.java	Before After	0	0	---
src/main/java/edu/harvard/iq/dataverse/DvObjectServiceBean.java	Before After	0	0	---
src/test/java/edu/harvard/iq/dataverse/api/SearchIT.java	Before After	0	1	---
src/main/java/edu/harvard/iq/dataverse/dataverse/DataverseUtil.java	Before After	18	0	---
doc/release-notes/12096-fix-ok-message-nested-object.md	Before After	27	0	---
src/main/java/edu/harvard/iq/dataverse/export/InternalExportDataProvider.java	Before After	0	0	---
src/main/java/edu/harvard/iq/dataverse/util/json/JsonParser.java	Before After	1	0	---
src/test/java/edu/harvard/iq/dataverse/api/UtilIT.java	Before After	0	0	---
doc/release-notes/11405-export-improvements.md	Before After	24	0	---
src/main/java/edu/harvard/iq/dataverse/externaltools/ExternalToolHandler.java	Before After	1	1	---
.github/workflows/deploy_beta_testing.yml	Before After	0	0	---
src/main/java/edu/harvard/iq/dataverse/engine/command/impl/CreateSavedSearchCommand.java	Before After	0	0	---
src/main/java/edu/harvard/iq/dataverse/api/Dataverses.java	Before After	0	0	---
doc/sphinx-guides/source/conf.py	Before After	0	0	---
src/test/java/edu/harvard/iq/dataverse/api/DataverseFeaturedItemsIT.java	Before After	0	1	---
src/test/java/edu/harvard/iq/dataverse/export/TabularDataExportIT.java	Before After	0	1	---
doc/release-notes/12190-previewers-for-public-aux-files.md	Before After	11	1	---
src/test/java/edu/harvard/iq/dataverse/util/json/JsonParserTest.java	Before After	0	0	---
doc/release-notes/12232-block-api-endpoints.md	Before After	14	9	---
doc/sphinx-guides/source/admin/features.md	Before After	0	6	---
doc/release-notes/11161-do-not-assume-default-license.md	Before After	8	0	---
src/main/java/edu/harvard/iq/dataverse/api/imports/ImportServiceBean.java	Before After	1	0	---
doc/release-notes/12450-expose-collection-guestbook-root-setting.md	Before After	6	0	---
doc/release-notes/12468-prov-fixes.md	Before After	6	0	---
doc/release-notes/12439-openapi.md	Before After	7	0	---
doc/release-notes/12346-DataCite-xml-updates.md	Before After	9	0	---
doc/release-notes/12200-async-reindexing-permissions.md	Before After	9	0	---
doc/release-notes/12543-request-timeout.md	Before After	7	0	---
doc/release-notes/12218-allow-perm-mgmt-without-edit.md	Before After	3	0	---
doc/release-notes/12362-factory-method-for-JSONbuilders.md	Before After	4	0	---
doc/release-notes/fix-indexes-for-guestbook-response.md	Before After	3	0	---
doc/release-notes/12413-disable-multipart-download-for-indirect-download.md	Before After	5	0	---
doc/release-notes/12523-guestbook-responses-page-stats-fix.md	Before After	2	0	---
doc/release-notes/11397-support-html-in-file-level-description.md	Before After	2	0	---
doc/release-notes/12331-multi-PID-support-in-external-vocabs.md	Before After	2	0	---
doc/release-notes/11594-release-time-inconsistency-api.md	Before After	2	0	---
doc/release-notes/11537-featured-items-retrieve-image-bug.md	Before After	3	0	---
doc/release-notes/12535-download-without-guestbook-response-for-preview-user2.md	Before After	2	0	---
doc/release-notes/12132-dataset-creation-with-template.md	Before After	3	0	---
doc/release-notes/12556-can-not-set-guestbook-with-id-over-127.md	Before After	3	0	---
src/test/java/edu/harvard/iq/dataverse/api/AuxiliaryFilesIT.java	Before After	2	1	---
doc/release-notes/12076-non-superuser-dataverse-linking.md	Before After	2	0	---
doc/release-notes/12412-fixed-license-acceptance-popup-for-archival-format.md	Before After	1	0	---
doc/release-notes/10103-rm-qa-guide.md	Before After	1	0	---
doc/release-notes/refactorddiexport.md	Before After	1	0	---
doc/release-notes/12536-password-reset-internationalization.md	Before After	1	0	---
doc/release-notes/12483-gbr-req-question-fix.md	Before After	1	0	---
doc/release-notes/12479-write-guestbook-improvements.md	Before After	1	0	---
doc/release-notes/12513-podman.md	Before After	1	0	---
src/main/java/edu/harvard/iq/dataverse/settings/SettingsServiceBean.java	Before After	5	5	---
src/test/java/edu/harvard/iq/dataverse/api/AdminSettingsSecretTest.java	Before After	21	21	---
.github/workflows/spi_release.yml	Before After	0	0	---
.github/workflows/container_integration_tests.yml	Before After	0	0	---
.github/workflows/codeql.yml	Before After	0	0	---
doc/sphinx-guides/source/user/dataset-management.rst	Before After	0	0	---
src/test/java/edu/harvard/iq/dataverse/settings/SettingsServiceBeanTest.java	Before After	8	8	---
doc/sphinx-guides/source/developers/aux-file-support.rst	Before After	0	0	---
doc/release-notes/mydata-bigint-classcastexception.md	Before After	1	1	---
doc/sphinx-guides/source/installation/prerequisites.rst	Before After	0	0	---
.github/workflows/container_app_pr.yml	Before After	0	0	---
.github/workflows/generate_war_file.yml	Before After	0	0	---
doc/sphinx-guides/source/api/changelog.rst	Before After	0	0	---
doc/sphinx-guides/source/api/native-api.rst	Before After	0	0	---
.github/workflows/dataverse_jsf_tests.yml	Before After	0	0	---
doc/sphinx-guides/source/api/external-tools.rst	Before After	0	0	---
src/main/webapp/dataset.xhtml	Before After	0	0	---
src/main/webapp/dataverse.xhtml	Before After	0	0	---
.github/workflows/maven_unit_test.yml	Before After	0	0	---
.github/workflows/deploy_to_internal.yml	Before After	0	0	---
doc/sphinx-guides/source/developers/troubleshooting.rst	Before After	0	0	---
.github/workflows/container_maintenance.yml	Before After	0	0	---
doc/sphinx-guides/source/user/dataverse-management.rst	Before After	0	0	---
src/main/java/edu/harvard/iq/dataverse/settings/JvmSettings.java	Before After	0	0	---
.github/workflows/container_app_push.yml	Before After	0	0	---
doc/sphinx-guides/source/installation/advanced.rst	Before After	0	0	---
src/main/webapp/editdatafiles.xhtml	Before After	0	0	---
doc/sphinx-guides/source/versions.rst	Before After	0	0	---
doc/sphinx-guides/source/developers/globus-api.rst	Before After	0	0	---
.github/workflows/maven_cache_management.yml	Before After	0	0	---
src/main/java/propertyFiles/Bundle.properties	Before After	0	0	---
doc/sphinx-guides/source/admin/dataverses-datasets.rst	Before After	0	0	---
src/main/webapp/metadataFragment.xhtml	Before After	0	0	---
.github/workflows/container_base_push.yml	Before After	0	0	---
doc/sphinx-guides/source/installation/config.rst	Before After	0	0	---

️ Biggest functions grown or shrunk by pull request

Which functions had their line count change as part of this pull request?