Review Fix dismissing GitHub cloud sessions (#336705)

This work implements Remote GitHub agent sessions cannot be dismissed from the Sessions list (open)

seen by @TylerLeonhardt

Description Remote GitHub agent sessions appear in VS Code's Sessions list, but they cannot be opened or marked as done. Selecting a session does nothing, and using Done leaves it in the list. The sessions can be archived from GitHub Copilot Agents, but that capability is not available from VS Code.

Steps to reproduce * Have one or more remote GitHub agent sessions associated with the account. * Open the Sessions list in VS Code. * Click a remote session, or invoke Done on it.

Actual: Clicking the session and marking it as done have no visible effect, so the item remains permanently in the list.

Expected: Remote sessions should support being opened and dismissed/archived from VS Code. Until that is supported, sessions that cannot be acted on or dismissed should not be shown in the list.

ljharb

microsoft/vscode

copilot/fix-remote-session-dismissal

Diff Delta:

Classified as: General

ljharb's Description of Work #336703 Remote GitHub agent sessions cannot be dismissed from the Sessions list

Fixes #336703

GitHub cloud session controllers currently advertise an archive setter even though their backend does not support archive mutations. This keeps archive state in VS Code local session storage for those sessions, while preserving controller-owned archive state for every other provider.

Adds a regression test that archives a cloud session, refreshes the provider catalog, and verifies the local state persists without a remote archive write.

Validation

npm run transpile-client -- --quiet

npm run eslint -- src/vs/workbench/contrib/chat/browser/agentSessions/agentSessionsModel.ts src/vs/workbench/contrib/chat/test/browser/agentSessions/agentSessionViewModel.test.ts

npm run test-browser-no-install -- --browser chromium-chrome --run src/vs/workbench/contrib/chat/test/browser/agentSessions/agentSessionViewModel.test.ts --grep "AgentSessionsViewModel - Session Archiving" (9 passing)

npm run typecheck-client -- --pretty false was attempted but exceeded the container memory limit

2 total changed files

Loading changes...

End of PR:

LGTM-land is officially in view

Fix dismissing GitHub cloud sessions #336705

ljharb's Description of Work #336703 Remote GitHub agent sessions cannot be dismissed from the Sessions list

Validation