Pull request #159749 quality checks

Code files and functions touched by this pull request are analyzed below.

Quality targets

How does this pull request compare to chosen code quality targets? Read more about code quality targets.

Target name	Target value	This PR
Maximum Diff Delta per PR	750	3040
Maximum comment count per PR	20	1
Pull request maximum business days between activity	3	1
Pull request maximum business days open	10	1

Coupled files

Are there any files from this commit that are always committed alongside another file? This often suggests that there exists code coupling to potentially remove. Read more about code coupling

Committed together %	Code file Coupled code file	Commits in PR with both
100	x-pack/plugin/esql/qa/fixture-common/src/main/java/org/elasticsearch/xpack/esql/datasources/fixtures/SplitPartitioner.java x-pack/plugin/esql/qa/fixture-common/src/main/java/org/elasticsearch/xpack/esql/datasources/fixtures/CsvFixtureParser.java	2
100	x-pack/plugin/esql/qa/fixture-common/src/test/java/org/elasticsearch/xpack/esql/datasources/fixtures/FixtureContractAuditTests.java x-pack/plugin/esql/qa/fixture-common/src/test/java/org/elasticsearch/xpack/esql/datasources/fixtures/FixtureMatrixTests.java	3
100	x-pack/plugin/esql/qa/fixture-common/src/test/java/org/elasticsearch/xpack/esql/datasources/fixtures/FixtureContractAuditTests.java x-pack/plugin/esql/qa/fixture-common/src/test/java/org/elasticsearch/xpack/esql/datasources/fixtures/FixtureDimensionsTests.java	3
100	x-pack/plugin/esql/qa/fixture-common/src/test/java/org/elasticsearch/xpack/esql/datasources/fixtures/FixtureContractAuditTests.java x-pack/plugin/esql/qa/fixture-common/src/main/java/org/elasticsearch/xpack/esql/datasources/fixtures/FixtureContractAudit.java	2
100	x-pack/plugin/esql/qa/fixture-common/src/test/java/org/elasticsearch/xpack/esql/datasources/fixtures/TextRowRendererTests.java x-pack/plugin/esql/qa/fixture-common/src/main/java/org/elasticsearch/xpack/esql/datasources/fixtures/TextRowRenderer.java	2
100	x-pack/plugin/esql/qa/server/single-node/src/javaRestTest/java/org/elasticsearch/xpack/esql/qa/single_node/DatasetRegistrationContractIT.java x-pack/plugin/esql/qa/fixture-common/src/test/java/org/elasticsearch/xpack/esql/datasources/fixtures/RegistrationContractTests.java	6
100	x-pack/plugin/esql/qa/server/single-node/src/javaRestTest/java/org/elasticsearch/xpack/esql/qa/single_node/DatasetRegistrationContractIT.java x-pack/plugin/esql/qa/fixture-common/src/main/java/org/elasticsearch/xpack/esql/datasources/fixtures/RegistrationContract.java	6
100	x-pack/plugin/esql/qa/fixture-common/src/test/java/org/elasticsearch/xpack/esql/datasources/fixtures/RegistrationContractTests.java x-pack/plugin/esql/qa/server/single-node/src/javaRestTest/java/org/elasticsearch/xpack/esql/qa/single_node/DatasetRegistrationContractIT.java	6
100	x-pack/plugin/esql/qa/fixture-common/src/test/java/org/elasticsearch/xpack/esql/datasources/fixtures/RegistrationContractTests.java x-pack/plugin/esql/qa/fixture-common/src/main/java/org/elasticsearch/xpack/esql/datasources/fixtures/RegistrationContract.java	6
100	x-pack/plugin/esql/qa/fixture-common/src/main/java/org/elasticsearch/xpack/esql/datasources/fixtures/RegistrationContract.java x-pack/plugin/esql/qa/server/single-node/src/javaRestTest/java/org/elasticsearch/xpack/esql/qa/single_node/DatasetRegistrationContractIT.java	6
100	x-pack/plugin/esql/qa/fixture-common/src/main/java/org/elasticsearch/xpack/esql/datasources/fixtures/RegistrationContract.java x-pack/plugin/esql/qa/fixture-common/src/test/java/org/elasticsearch/xpack/esql/datasources/fixtures/RegistrationContractTests.java	6
84	x-pack/plugin/esql/qa/fixture-common/src/main/java/org/elasticsearch/xpack/esql/datasources/fixtures/FixtureCapabilities.java x-pack/plugin/esql/qa/fixture-common/src/test/java/org/elasticsearch/xpack/esql/datasources/fixtures/FixtureDimensionsTests.java	1
81	x-pack/plugin/esql/qa/fixture-common/src/main/java/org/elasticsearch/xpack/esql/datasources/fixtures/FixtureContractAudit.java x-pack/plugin/esql/qa/fixture-common/src/main/java/org/elasticsearch/xpack/esql/datasources/fixtures/FixtureDimensions.java	1
80	x-pack/plugin/esql/qa/fixture-common/src/main/java/org/elasticsearch/xpack/esql/datasources/fixtures/TextRowRenderer.java x-pack/plugin/esql/qa/fixture-common/src/test/java/org/elasticsearch/xpack/esql/datasources/fixtures/TextRowRendererTests.java	2
80	x-pack/plugin/esql/qa/fixture-common/src/test/java/org/elasticsearch/xpack/esql/datasources/fixtures/FixtureMatrixTests.java x-pack/plugin/esql/qa/fixture-common/src/test/java/org/elasticsearch/xpack/esql/datasources/fixtures/FixtureDimensionsTests.java	3
78	x-pack/plugin/esql/qa/fixture-common/src/test/java/org/elasticsearch/xpack/esql/datasources/fixtures/FixtureExclusionsTests.java x-pack/plugin/esql/qa/fixture-common/src/main/java/org/elasticsearch/xpack/esql/datasources/fixtures/FixtureExclusions.java	1
78	x-pack/plugin/esql/qa/fixture-common/src/main/java/org/elasticsearch/xpack/esql/datasources/fixtures/FixtureExclusions.java x-pack/plugin/esql/qa/fixture-common/src/test/java/org/elasticsearch/xpack/esql/datasources/fixtures/FixtureExclusionsTests.java	1
76	x-pack/plugin/esql/qa/fixture-common/src/test/java/org/elasticsearch/xpack/esql/datasources/fixtures/FixtureDimensionsTests.java x-pack/plugin/esql/qa/fixture-common/src/main/java/org/elasticsearch/xpack/esql/datasources/fixtures/FixtureDimensions.java	3
76	x-pack/plugin/esql/qa/fixture-common/src/main/java/org/elasticsearch/xpack/esql/datasources/fixtures/FixtureDimensions.java x-pack/plugin/esql/qa/fixture-common/src/test/java/org/elasticsearch/xpack/esql/datasources/fixtures/FixtureDimensionsTests.java	3
75	x-pack/plugin/esql/qa/fixture-common/src/test/java/org/elasticsearch/xpack/esql/datasources/fixtures/CsvFixtureParserTests.java x-pack/plugin/esql/qa/fixture-common/src/main/java/org/elasticsearch/xpack/esql/datasources/fixtures/FixtureMatrix.java	2
75	x-pack/plugin/esql/qa/fixture-common/src/test/java/org/elasticsearch/xpack/esql/datasources/fixtures/CsvFixtureParserTests.java x-pack/plugin/esql/qa/fixture-common/src/main/java/org/elasticsearch/xpack/esql/datasources/fixtures/CsvFixtureParser.java	2
75	x-pack/plugin/esql/qa/fixture-common/src/test/java/org/elasticsearch/xpack/esql/datasources/fixtures/TextRowRendererTests.java x-pack/plugin/esql/qa/fixture-common/src/main/java/org/elasticsearch/xpack/esql/datasources/fixtures/FixtureMatrix.java	2

Biggest files changes in pull request

Path	View whole file	Lines added	Final line count
x-pack/plugin/esql/qa/fixture-common/src/main/java/org/elasticsearch/xpack/esql/datasources/fixtures/FixtureDimensions.java	Before After	169	1831
x-pack/plugin/esql/qa/fixture-common/src/main/java/org/elasticsearch/xpack/esql/datasources/fixtures/RegistrationContract.java	Before After	365	365
x-pack/plugin/esql/qa/fixture-common/src/test/java/org/elasticsearch/xpack/esql/datasources/fixtures/FixtureDimensionsTests.java	Before After	425	1468
x-pack/plugin/esql/qa/server/single-node/src/javaRestTest/java/org/elasticsearch/xpack/esql/qa/single_node/DatasetRegistrationContractIT.java	Before After	286	---
x-pack/plugin/esql/qa/fixture-common/src/test/java/org/elasticsearch/xpack/esql/datasources/fixtures/RegistrationContractTests.java	Before After	258	---
x-pack/plugin/esql/qa/fixture-common/src/test/java/org/elasticsearch/xpack/esql/datasources/fixtures/FixtureMatrixTests.java	Before After	338	338
x-pack/plugin/esql/qa/fixture-common/src/test/java/org/elasticsearch/xpack/esql/datasources/fixtures/FixtureExclusionsTests.java	Before After	335	335
x-pack/plugin/esql/qa/fixture-common/src/test/java/org/elasticsearch/xpack/esql/datasources/fixtures/FixtureContractAuditTests.java	Before After	198	198
x-pack/plugin/esql/qa/fixture-common/README.md	Before After	274	274
x-pack/plugin/esql/qa/fixture-common/src/main/java/org/elasticsearch/xpack/esql/datasources/fixtures/FixtureMatrix.java	Before After	622	622
x-pack/plugin/esql/qa/fixture-common/src/main/java/org/elasticsearch/xpack/esql/datasources/fixtures/FixtureContractAudit.java	Before After	256	256
x-pack/plugin/esql/qa/fixture-common/src/test/java/org/elasticsearch/xpack/esql/datasources/fixtures/DimensionDiscriminationTests.java	Before After	159	159
x-pack/plugin/esql/qa/fixture-common/fixture-vector-tasks.gradle	Before After	0	---
x-pack/plugin/esql/qa/fixture-common/src/main/java/org/elasticsearch/xpack/esql/datasources/fixtures/FixtureExclusions.java	Before After	398	398
x-pack/plugin/esql/qa/fixture-common/src/main/java/org/elasticsearch/xpack/esql/datasources/fixtures/CaseShard.java	Before After	105	105
x-pack/plugin/esql/qa/fixture-common/src/main/resources/org/elasticsearch/xpack/esql/datasources/fixtures/fixture-dimensions.properties	Before After	0	---
x-pack/plugin/esql/qa/fixture-common/src/main/java/org/elasticsearch/xpack/esql/datasources/fixtures/HivePartitioner.java	Before After	0	---
x-pack/plugin/esql/qa/fixture-common/fixture-layouts.gradle	Before After	0	---
x-pack/plugin/esql/qa/fixture-common/src/main/resources/org/elasticsearch/xpack/esql/datasources/fixtures/registration-contract.properties	Before After	0	---
x-pack/plugin/esql/qa/fixture-common/src/test/java/org/elasticsearch/xpack/esql/datasources/fixtures/CsvFixtureParserTests.java	Before After	0	---
x-pack/plugin/esql/qa/fixture-common/fixture-manifest.gradle	Before After	0	---
x-pack/plugin/esql/qa/fixture-common/src/test/java/org/elasticsearch/xpack/esql/datasources/fixtures/CaseShardTests.java	Before After	106	106
x-pack/plugin/esql/qa/fixture-common/src/test/java/org/elasticsearch/xpack/esql/datasources/fixtures/TextRowRendererTests.java	Before After	0	---
x-pack/plugin/esql/qa/fixture-common/src/main/java/org/elasticsearch/xpack/esql/datasources/fixtures/CsvFixtureParser.java	Before After	0	---
x-pack/plugin/esql/qa/fixture-common/fixture-coverage.gradle	Before After	0	---
x-pack/plugin/esql/qa/fixture-common/fixture-matrix.gradle	Before After	0	---
x-pack/plugin/esql/qa/fixture-common/src/main/java/org/elasticsearch/xpack/esql/datasources/fixtures/TextRowRenderer.java	Before After	0	---
x-pack/plugin/esql/qa/fixture-common/src/main/java/org/elasticsearch/xpack/esql/datasources/fixtures/FixtureCapabilities.java	Before After	162	162
x-pack/plugin/esql/qa/fixture-common/src/main/java/org/elasticsearch/xpack/esql/datasources/fixtures/SplitPartitioner.java	Before After	0	---
x-pack/plugin/esql/qa/fixture-common/src/main/java/org/elasticsearch/xpack/esql/datasources/fixtures/DeclaredSchemas.java	Before After	0	---
x-pack/plugin/esql/qa/fixture-common/fixture-variants.gradle	Before After	0	---
x-pack/plugin/esql/qa/fixture-common/build.gradle	Before After	0	---
x-pack/plugin/esql/qa/fixture-common/dimension-contract.gradle	Before After	0	---
x-pack/plugin/esql/qa/fixture-common/src/main/resources/org/elasticsearch/xpack/esql/datasources/fixtures/fixture-exclusions.properties	Before After	0	---
x-pack/plugin/esql/qa/fixture-common/src/main/resources/org/elasticsearch/xpack/esql/datasources/fixtures/dataset-registration-cases.properties	Before After	0	---
x-pack/plugin/esql/qa/server/single-node/build.gradle	Before After	0	---
x-pack/plugin/esql/qa/fixture-common/src/main/resources/org/elasticsearch/xpack/esql/datasources/fixtures/fixture-matrix.properties	Before After	0	---

️ Biggest functions grown or shrunk by pull request

Which functions had their line count change as part of this pull request?

Qualified function name	View whole function	Lines added	Final line count
FixtureDimensions::parse	Before After	51	498
RegistrationContract::parse	Before After	78	130
FixtureDimensions	Before After	2	40
FixtureDimensions	Before After	2	38
FixtureDimensions::seamServes	Before After	8	28
RegistrationContractTests::testEveryMessageNamesSomethingTheCasePinned	Before After	23	27
FixtureDimensionsTests::testClusterSettingsCarryOnlyClusterBoundSlotsOffTheirDefault	Before After	24	23
RegistrationContract::Case	Before After	3	23
FixtureDimensionsTests::testAMalformedValueDisjointEntryIsRejected	Before After	23	22
FixtureExclusionsTests::testAnExclusionMustCarryATypedReason	Before After	22	21
RegistrationContract::Case	Before After	13	21
FixtureMatrix::paddedForTemplate	Before After	1	21
RegistrationContractTests::testTheDeclaredContractIsComplete	Before After	9	18
FixtureMatrixTests::testUnrepresentableDialectsStackAndMustBeExplained	Before After	18	17
RegistrationContract::nameOf	Before After	6	17
RegistrationContract::declaredColumns	Before After	17	16
FixtureMatrixTests::testARestrictedDatasetNeedsAReasonAndRealFormats	Before After	16	15
FixtureExclusionsTests::testAnExclusionKeyMustNameBothSpecAndCase	Before After	15	14
FixtureDimensionsTests::testAVectorNameCarriesTheOffDefaultSlotsAndRoundTrips	Before After	15	14
FixtureDimensionsTests::testADisjointPairBlamedOnADefectMustCiteIt	Before After	15	14
RegistrationContract::parse::Case	Before After	14	13
FixtureMatrixTests::testAnUndeclaredDatasetRefusesToGuessItsPaddingOrDialect	Before After	14	13
RegistrationContract::Case	Before After	1	13
FixtureExclusionsTests::testASharedReasonIsResolvedForEveryEntryThatReferencesIt	Before After	13	12
FixtureMatrixTests::testAWholeFileExclusionMustDeclareItsReason	Before After	13	12
FixtureDimensionsTests::testARejectionMustNameARealValueAndFormat	Before After	12	11
FixtureDimensionsTests::testAStrayTopLevelKeyIsRejectedUnlessItIsAReason	Before After	12	11
FixtureDimensionsTests::testAnAbsenceMustNameARealValueAndFormat	Before After	12	11
FixtureDimensionsTests::testDerivedValuesMustNameSomethingDeclared	Before After	12	11
FixtureDimensionsTests::testADimensionWithoutADefaultIsRejected	Before After	12	11
DatasetRegistrationContractIT::initFixtureDir	Before After	3	11
FixtureMatrixTests::testABlankCodecListIsRefusedLikeAnAbsentOne	Before After	11	10
FixtureDimensionsTests::testADataSourceDimensionTravelsUnderItsOwnKeyAndNotTheDirectiveOne	Before After	10	10
RegistrationContractTests::testEveryBlockedCaseInTheContractCitesAnIssue	Before After	10	9
FixtureDimensionsTests::testARejectedValueIsServedOnlyByTheRegistrationSeam	Before After	10	9
RegistrationContractTests::testTheResourceFormIsDeclaredAndValidated	Before After	9	8
RegistrationContractTests::testABlockedCaseMustCiteTheIssueThatWillUnblockIt	Before After	9	8
RegistrationContractTests::testACaseMayRegisterMoreThanOneSetting	Before After	9	8
FixtureDimensionsTests::testACellCannotBeBothAbsentAndRejected	Before After	8	7
FixtureDimensionsTests::testATierMustNameADeclaredFormat	Before After	8	7
FixtureMatrixTests::testALayoutWithNoSourceDatasetFallsBackRatherThanThrowing	Before After	8	7
FixtureMatrixTests::testADerivedLayoutResolvesToTheDatasetItIsBuiltFrom	Before After	8	7
FixtureMatrixTests::testAMissingCodecListIsRefusedRatherThanReadAsEmpty	Before After	8	7
RegistrationContractTests::testEveryRequiredFieldIsRequired	Before After	2	7
RegistrationContractTests::testEveryMessageNamesASettingTheCaseRegisters	Before After	1	7
RegistrationContractTests::testAWellFormedCaseParses	Before After	1	7
RegistrationContractTests::testACaseWithNoSettingsIsRejected	Before After	7	6
FixtureMatrixTests::minimalDeclaration	Before After	7	6
FixtureMatrixTests::testAnUnrecognisedKeyIsRejected	Before After	7	6
RegistrationContractTests::wellFormed	Before After	3	6
RegistrationContractTests::testACaseMayAssertASubstringIsAbsent	Before After	6	5
RegistrationContractTests::testAnUnknownOutcomeIsRejected	Before After	6	5
RegistrationContractTests::testARefusedCaseMayNotDeclareAQuery	Before After	6	5
RegistrationContractTests::testTheContractCarriesAtLeastOneCombination	Before After	6	5
FixtureExclusionsTests::testAnUnresolvedSharedReasonIsRejected	Before After	6	5
FixtureExclusionsTests::testAnExclusionForAnUndeclaredSuiteIsRejected	Before After	6	5
FixtureExclusionsTests::testAnUnknownKeyIsRejectedRatherThanSkipped	Before After	6	5
FixtureDimensionsTests::testAPerFormatRejectionWinsOverABareOne	Before After	6	5
FixtureDimensionsTests::testAnUnverifiedPairIsTreatedAsInteracting	Before After	6	5
FixtureDimensionsTests::testTheDelimiterSpellingResolvesToOneCharacter	Before After	6	5
FixtureDimensionsTests::testAMultiCharacterSpellingForACharValuedSlotIsRejected	Before After	6	5
FixtureMatrixTests::testAStandaloneTemplateResolvesToItselfAndItsDialect	Before After	6	5
FixtureMatrixTests::testPaddingIsDeclaredPerDatasetAndOnlyAppliesToCsv	Before After	6	5
FixtureMatrixTests::testSnapshotOnlyTextCodecsAreWithheldFromAReleaseBuild	Before After	6	5
FixtureContractAuditTests::testTheAuditRefusesAnythingButOneArgument	Before After	6	5
FixtureDimensionsTests::testAKeyOnABindThatCarriesNoneIsRejected	Before After	2	5
RegistrationContractTests::testABlankFieldIsRefusedLikeAnAbsentOne	Before After	1	5
RegistrationContractTests::testAnUnknownAttributeIsRejected	Before After	1	5
FixtureExclusionsTests::declared	Before After	5	4
FixtureDimensions::rejectionMessage	Before After	5	4
FixtureDimensionsTests::testRefusingTheDefaultIsRejected	Before After	5	4
FixtureDimensionsTests::testARejectionWithoutAMessageIsRefused	Before After	5	4
FixtureDimensionsTests::testARejectedValueCarriesTheMessageItMustBeRefusedWith	Before After	5	4
FixtureDimensionsTests::testABackendMappingMustNameADeclaredValue	Before After	5	4
FixtureDimensionsTests::testAPerValueAttributeWithoutItsValueIsRejected	Before After	5	4
FixtureDimensionsTests::testAnAttributeQualifierIsRejectedWhereNoneIsTaken	Before After	5	4
FixtureDimensionsTests::testACodecExtensionComesFromTheDeclaration	Before After	5	4
FixtureDimensionsTests::testAPerFormatDefaultOutsideItsValuesIsRejected	Before After	5	4
FixtureDimensionsTests::testAValueMappingForAnUnknownDimensionIsRejected	Before After	5	4
FixtureDimensionsTests::testAMalformedDimensionKeyIsRejected	Before After	5	4
FixtureDimensionsTests::testTheDataSourceCellIsServedOnlyByTheDataSourceSeam	Before After	5	4
FixtureDimensionsTests::testDataSourceSettingsOmitSlotsAtTheirDefault	Before After	5	4
FixtureMatrixTests::testABlankSpecExclusionListExcludesNothing	Before After	5	4
FixtureMatrixTests::testAParquetSuiteOverrideNarrowsTheCodecSet	Before After	5	4
FixtureContractAuditTests::noExclusions	Before After	5	4
RegistrationContractTests::testAnExplicitFormatOverridesTheDefault	Before After	1	4
DatasetRegistrationContractIT::resourceFor	Before After	4	3
FixtureExclusionsTests::testAMissingSuitesListIsRejected	Before After	4	3
FixtureDimensionsTests::testAskingForAVerdictOnAnUnknownPairIsRejected	Before After	4	3
FixtureDimensionsTests::testAskingForAnUnknownDimensionIsRejected	Before After	4	3
FixtureDimensionsTests::testTierNamesAreMatchedCaseInsensitively	Before After	4	3
FixtureDimensionsTests::testTheTabEscapeDecodesToARealTab	Before After	4	3
FixtureDimensionsTests::testAnUnknownTierIsRejected	Before After	4	3
RegistrationContractTests::testEveryOutcomeHasACase	Before After	3	3
RegistrationContractTests::testTheContractCarriesBothOutcomes	Before After	1	3
RegistrationContract::Case::blocked	Before After	3	2
FixtureMatrix::parse	Before After	3	2
FixtureDimensions::keyFor	Before After	3	2
FixtureMatrixTests::testADatasetWithNoDeclaredUnrepresentableDialectsHasNone	Before After	3	2
FixtureMatrixTests::testASuiteWithNoDeclaredExclusionsExcludesNothing	Before After	3	2
FixtureDimensions::dataSourceKey	Before After	2	2
FixtureDimensions::directiveKey	Before After	1	2

ES|QL|DS: A declaration for external-datasource behaviour, demonstrated on dataset registration #159749

Pull request #159749 quality checks

Quality targets

Coupled files

Biggest files changes in pull request

️ Biggest functions grown or shrunk by pull request