This pull request has been designated for reprocessing. Please check back in a few minutes.

Home » Oreps » Elasticsearch » All Pull Requests » #159736
elastic/elasticsearch
Free and Open Source, Distributed, RESTful Search Engine
Watch
1
Commit Activity
Pull Requests
Directory Browser
Velocity History
Releases

ES|QL|DS: hide storage location without privilege #159736

Compare code on GitHub
Open
luigidellaquila opened 2:40pm on September 18, 2026 wants to merge 1425 Δ into elastic/elasticsearch main from
esql/ds/hide_dataset_location

Pull request #159736 quality checks

Code files and functions touched by this pull request are analyzed below.

Quality targets

How does this pull request compare to chosen code quality targets? Read more about code quality targets.

Target name Target value This PR
Maximum Diff Delta per PR 750 1425
Maximum comment count per PR 20 1
Pull request maximum business days between activity 3 1
Pull request maximum business days open 10 1

Coupled files

Are there any files from this commit that are always committed alongside another file? This often suggests that there exists code coupling to potentially remove. Read more about code coupling

Committed together % Code file
Coupled code file 		Commits in PR with both
100 x-pack/plugin/esql/src/test/java/org/elasticsearch/xpack/esql/datasources/FormatNameResolverTests.java
x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/datasources/FormatNameResolver.java 		1
100 x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/session/ConfigurationBuilder.java
x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/session/Configuration.java 		1
100 x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/session/ConfigurationBuilder.java
x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/session/EsqlSession.java 		1
100 x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/datasources/spi/TableCatalog.java
x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/datasources/FileSourceFactory.java 		1
100 x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/datasources/spi/TableCatalog.java
x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/datasources/ExternalSourceResolver.java 		1
100 x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/datasources/spi/TableCatalog.java
x-pack/plugin/esql/src/test/java/org/elasticsearch/xpack/esql/datasources/ExternalSourceResolverTests.java 		1
90 x-pack/plugin/esql-datasource-s3/src/test/java/org/elasticsearch/xpack/esql/datasource/s3/S3StorageObjectReadFailureTests.java
x-pack/plugin/esql-datasource-s3/src/main/java/org/elasticsearch/xpack/esql/datasource/s3/S3StorageObject.java 		1
90 x-pack/plugin/esql/src/test/java/org/elasticsearch/xpack/esql/datasources/ExternalSourceResolverTests.java
x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/datasources/ExternalSourceResolver.java 		1
87 x-pack/plugin/esql-datasource-azure/src/main/java/org/elasticsearch/xpack/esql/datasource/azure/AzureStorageObject.java
x-pack/plugin/esql-datasource-s3/src/main/java/org/elasticsearch/xpack/esql/datasource/s3/S3StorageObject.java 		1
84 x-pack/plugin/esql-datasource-parquet/src/test/java/org/elasticsearch/xpack/esql/datasource/parquet/ParquetFormatReaderTests.java
x-pack/plugin/esql-datasource-parquet/src/main/java/org/elasticsearch/xpack/esql/datasource/parquet/ParquetFormatReader.java 		1
81 x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/plan/logical/ExternalRelation.java
x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/plan/physical/ExternalSourceExec.java 		1
80 x-pack/plugin/esql-datasource-s3/src/test/java/org/elasticsearch/xpack/esql/datasource/s3/S3AnonymousAccessTests.java
x-pack/plugin/esql-datasource-s3/src/main/java/org/elasticsearch/xpack/esql/datasource/s3/S3StorageProvider.java 		1
76 x-pack/plugin/esql-datasource-gcs/src/main/java/org/elasticsearch/xpack/esql/datasource/gcs/GcsStorageProvider.java
x-pack/plugin/esql-datasource-s3/src/main/java/org/elasticsearch/xpack/esql/datasource/s3/S3StorageProvider.java 		1
75 x-pack/plugin/esql-datasource-azure/src/main/java/org/elasticsearch/xpack/esql/datasource/azure/AzureStorageProvider.java
x-pack/plugin/esql-datasource-s3/src/main/java/org/elasticsearch/xpack/esql/datasource/s3/S3StorageProvider.java 		1
70 x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/datasources/FormatNameResolver.java
x-pack/plugin/esql/src/test/java/org/elasticsearch/xpack/esql/datasources/FormatNameResolverTests.java 		1

Biggest files changes in pull request

Estimated line counts are shown. Values may change once change summary has finished building.

Path View whole file Lines removed Lines added Final line count
x-pack/plugin/esql-datasource-s3/src/javaRestTest/java/org/elasticsearch/xpack/esql/datasource/s3/qa/DatasetLocationSecurityIT.java BeforeAfter 0 314 ---
x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/session/EsqlSession.java BeforeAfter 1 115 ---
x-pack/plugin/esql/src/test/java/org/elasticsearch/xpack/esql/datasources/ExternalSourceResolverTests.java BeforeAfter 17 31 ---
x-pack/plugin/esql-datasource-parquet/src/main/java/org/elasticsearch/xpack/esql/datasource/parquet/ParquetFormatReader.java BeforeAfter 8 1 ---
x-pack/plugin/esql-datasource-s3/src/main/java/org/elasticsearch/xpack/esql/datasource/s3/S3StorageObject.java BeforeAfter 18 0 ---
x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/datasources/ExternalSourceResolver.java BeforeAfter 6 31 ---
x-pack/plugin/esql-datasource-azure/src/main/java/org/elasticsearch/xpack/esql/datasource/azure/AzureStorageObject.java BeforeAfter 3 0 ---
x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/session/Configuration.java BeforeAfter 1 42 ---
x-pack/plugin/esql-datasource-s3/src/main/java/org/elasticsearch/xpack/esql/datasource/s3/S3StorageProvider.java BeforeAfter 12 3 ---
x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/datasources/FormatNameResolver.java BeforeAfter 6 1 ---
x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/datasources/ExternalFailures.java BeforeAfter 19 33 ---
x-pack/plugin/esql-datasource-gcs/src/main/java/org/elasticsearch/xpack/esql/datasource/gcs/GcsStorageObject.java BeforeAfter 8 0 ---
x-pack/plugin/esql-datasource-gcs/src/main/java/org/elasticsearch/xpack/esql/datasource/gcs/GcsStorageProvider.java BeforeAfter 9 3 ---
x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/datasources/FileSourceFactory.java BeforeAfter 2 1 ---
x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/datasources/RetryableStorageObject.java BeforeAfter 0 0 ---
x-pack/plugin/esql-datasource-parquet/src/test/java/org/elasticsearch/xpack/esql/datasource/parquet/ParquetFormatReaderTests.java BeforeAfter 4 0 ---
x-pack/plugin/esql-datasource-azure/src/main/java/org/elasticsearch/xpack/esql/datasource/azure/AzureStorageProvider.java BeforeAfter 2 0 ---
x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/core/tree/NodeStringMapper.java BeforeAfter 0 46 ---
x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/session/ConfigurationBuilder.java BeforeAfter 0 8 ---
x-pack/plugin/esql/src/test/java/org/elasticsearch/xpack/esql/anonymizer/PlanAnonymizerTests.java BeforeAfter 0 30 ---
x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/plugin/ComputeService.java BeforeAfter 0 7 ---
x-pack/plugin/esql-datasource-s3/src/javaRestTest/resources/dataset_location_security_roles.yml BeforeAfter 0 24 ---
x-pack/plugin/esql/src/test/java/org/elasticsearch/xpack/esql/datasources/FileSplitProviderTests.java BeforeAfter 1 0 ---
x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/plan/physical/ExternalSourceExec.java BeforeAfter 3 5 ---
x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/plan/logical/ExternalRelation.java BeforeAfter 2 3 ---
x-pack/plugin/esql-datasource-s3/src/test/java/org/elasticsearch/xpack/esql/datasource/s3/S3StorageObjectReadFailureTests.java BeforeAfter 0 0 ---
x-pack/plugin/esql/src/test/java/org/elasticsearch/xpack/esql/datasources/FormatNameResolverTests.java BeforeAfter 0 0 ---
x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/datasources/spi/TableCatalog.java BeforeAfter 0 0 ---
x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/core/anonymizer/AnonymizationContext.java BeforeAfter 1 6 ---
x-pack/plugin/esql-datasource-s3/src/test/java/org/elasticsearch/xpack/esql/datasource/s3/S3AnonymousAccessTests.java BeforeAfter 0 0 ---
server/src/main/resources/transport/upper_bounds/9.6.csv BeforeAfter 0 0 ---
server/src/main/resources/transport/definitions/referable/esql_dataset_location_visible.csv BeforeAfter 0 0 ---

️ Biggest functions grown or shrunk by pull request

Which functions had their line count change as part of this pull request?

Estimated line counts are shown. Values may change once change summary has finished building.

Qualified function name View whole function Lines removed Lines added Final line count
EsqlSession::analyseAndExecute::onResponse BeforeAfter 1 1 119
ParquetFormatReaderTests::testValidateFooterIntegrityPassesForOptionalColumnWithNulls BeforeAfter 1 1 25
FormatNameResolver::ambiguousDatasetFormatMessage BeforeAfter 2 2 7
nodeString BeforeAfter 2 2 6
FormatNameResolver::ambiguousDatasetFormatMessage BeforeAfter 1 1 3
ExternalSourceResolver::mapResolveFailure 5 5 ---
FormatNameResolver::listedFormatConflictMessage 3 3 ---
GitClear uses cookies to ensure you get the best experience on our website. Learn more about our cookie policy