Home » Oreps » Elasticsearch » All Pull Requests » #159708
elastic/elasticsearch
Free and Open Source, Distributed, RESTful Search Engine
Watch
1
Commit Activity
Pull Requests
Directory Browser
Velocity History
Releases

[9.4] SQL: Fix internal server error on an aggregate over an aggregate alias (#159256) #159708

Compare code on GitHub
Merged
bpintea opened 11:38am on September 18, 2026 wanted to merge 381 Δ into elastic/elasticsearch 9.4 from
backport/9.4/pr-159256

Pull request #159708 quality checks

Code files and functions touched by this pull request are analyzed below.

Quality targets

How does this pull request compare to chosen code quality targets? Read more about code quality targets.

Target name Target value This PR
Maximum Diff Delta per PR 750 381
Maximum comment count per PR 20 0
Pull request maximum business days between activity 3 1
Pull request maximum business days open 10 1

Coupled files

Are there any files from this commit that are always committed alongside another file? This often suggests that there exists code coupling to potentially remove. Read more about code coupling

Committed together % Code file
Coupled code file 		Commits in PR with both
90 x-pack/plugin/sql/src/test/java/org/elasticsearch/xpack/sql/optimizer/OptimizerTests.java
x-pack/plugin/sql/src/test/java/org/elasticsearch/xpack/sql/planner/QueryTranslatorTests.java 		1
76 x-pack/plugin/sql/src/main/java/org/elasticsearch/xpack/sql/analysis/analyzer/Verifier.java
x-pack/plugin/sql/src/test/java/org/elasticsearch/xpack/sql/analysis/analyzer/VerifierErrorMessagesTests.java 		1

Biggest files changes in pull request

Path View whole file Lines removed Lines added Final line count
x-pack/plugin/sql/src/main/java/org/elasticsearch/xpack/sql/optimizer/Optimizer.java BeforeAfter 10 59 1277
x-pack/plugin/sql/src/test/java/org/elasticsearch/xpack/sql/optimizer/OptimizerTests.java BeforeAfter 0 183 1382
x-pack/plugin/sql/src/test/java/org/elasticsearch/xpack/sql/planner/QueryTranslatorTests.java BeforeAfter 0 108 1530
x-pack/plugin/sql/src/main/java/org/elasticsearch/xpack/sql/analysis/analyzer/Analyzer.java BeforeAfter 0 37 1212
x-pack/plugin/sql/src/test/java/org/elasticsearch/xpack/sql/analysis/analyzer/VerifierErrorMessagesTests.java BeforeAfter 0 48 1815
x-pack/plugin/sql/src/main/java/org/elasticsearch/xpack/sql/analysis/analyzer/Verifier.java BeforeAfter 0 36 1084
x-pack/plugin/sql/src/main/java/org/elasticsearch/xpack/sql/expression/function/aggregate/SingleValueIdentityAgg.java BeforeAfter 0 27 27
x-pack/plugin/sql/src/main/java/org/elasticsearch/xpack/sql/expression/function/aggregate/Percentile.java BeforeAfter 0 0 34
x-pack/plugin/sql/src/main/java/org/elasticsearch/xpack/sql/expression/function/aggregate/Avg.java BeforeAfter 0 0 40
x-pack/plugin/sql/src/main/java/org/elasticsearch/xpack/sql/expression/function/aggregate/Max.java BeforeAfter 0 0 59
x-pack/plugin/sql/src/main/java/org/elasticsearch/xpack/sql/expression/function/aggregate/Sum.java BeforeAfter 0 0 50
x-pack/plugin/sql/src/main/java/org/elasticsearch/xpack/sql/expression/function/aggregate/Min.java BeforeAfter 0 0 59
docs/changelog/159256.yaml BeforeAfter 0 6 6
x-pack/plugin/sql/qa/server/src/main/resources/agg.csv-spec BeforeAfter 0 0 ---

️ Biggest functions grown or shrunk by pull request

Which functions had their line count change as part of this pull request?

Qualified function name View whole function Lines removed Lines added Final line count
Verifier::verify BeforeAfter 0 1 165
OptimizerTests::testSumOfSumSharingStatsPromotionCollapsesToInnerAggregate BeforeAfter 0 32 31
QueryTranslatorTests::testReplaceSumWithStatsThroughAliasedHaving BeforeAfter 0 24 23
OptimizerTests::testSumOverAggregateExpressionIsLeftUnchanged BeforeAfter 0 23 22
OptimizerTests::testCollapseAppliesToAnyInnerAggregate BeforeAfter 0 16 20
Optimizer::ReplaceSumWithStats::apply BeforeAfter 0 14 20
QueryTranslatorTests::testMinOfMinAliasInOrderByCollapsesToSingleMinAgg BeforeAfter 0 19 18
OptimizerTests::testCollapseDoesNotApplyToCountOrPercentileRankAsOuter BeforeAfter 0 11 18
OptimizerTests::testCollapseAppliesToAnyInnerAggregate::testCollapseDoesNotApplyToCountOrPercentileRankAsOuter BeforeAfter 0 7 18
OptimizerTests::testCollapseDoesNotApplyToCountOrPercentileRankAsOuter::testPercentileOverAggregateExpressionIsLeftUnchanged BeforeAfter 0 17 16
QueryTranslatorTests::testAvgOfAvgAliasInHavingCollapsesToSingleAvgAgg BeforeAfter 0 17 16
QueryTranslatorTests::testSumOfCountAliasInHavingCollapsesToSingleCountAgg BeforeAfter 0 15 14
Analyzer::HavingOverProject::findMissingAggregate BeforeAfter 0 4 14
OptimizerTests::testCollapseAvgOverAvgCollapsesToInner BeforeAfter 0 13 12
VerifierErrorMessagesTests::testNonCollapsibleAggregateOverAggregateAliasIsRejected BeforeAfter 0 13 12
OptimizerTests::testCollapsePercentileOverMaxCollapsesToInner BeforeAfter 0 12 11
OptimizerTests::testCollapseMinOverSumCollapsesToInner BeforeAfter 0 12 11
QueryTranslatorTests::testPercentileOfPercentileAliasInHavingCollapsesToSinglePercentilesAgg BeforeAfter 0 12 11
VerifierErrorMessagesTests::testNestedAggregateFunctionInExpression BeforeAfter 0 12 11
VerifierErrorMessagesTests::testIdentityAggregateOverAggregateAliasIsAccepted BeforeAfter 0 10 9
OptimizerTests::testCollapseAppliesToAnyInnerAggregate::Aggregate BeforeAfter 0 9 8
Analyzer::aggregateAliases BeforeAfter 0 9 8
Optimizer::CollapseAggregateOverAggregate::apply BeforeAfter 0 8 7
OptimizerTests::testCollapseAppliesToAnyInnerAggregate::testCollapseDoesNotApplyToCountOrPercentileRankAsOuter::Aggregate BeforeAfter 0 6 5
GitClear uses cookies to ensure you get the best experience on our website. Learn more about our cookie policy