[Ledgers] Add the row ID to the dedupe map #37589

Open
acdlite opened 11:07am on September 11, 2026 wants to merge 122 Ξ” into facebook/react ledgers/1-flag from
ledgers/2-dedupe-map

Pull Request Overview

  • Opened on September 11, 2026
  • Status Open
  • Commit count 1 with first commit September 14, 2026

Total Delta

122 Total Diff Delta

Open Days

Open 6 weekdays

Test Delta

0 Diff Delta in Test Files
Breakdown by Phase

How long has this pull request spent in each phase of its lifecycle?

Fraction of total time Business days Phase
 
0.0 days Authoring 0 commits before pull request opened for review
 
0.1 days Awaiting first review
 
5.1 days Revising work with 1 commit in response to 2 reviews that left 2 comments

Total time for pull request still awaiting merge (longer than repo's target): 5.2 business days

Author avatar

[Ledgers] Add the row ID to the dedupe map

Small refactor to prepare for Ledgers.

Changes the type of the value in object deduping map (writtenObjects) from string (a reference to an object already written to the response) to {id: number, reference: string} instead. reference is the same string as before, and id is the row ID of the object.

The motivation is so a consumer of the dedupe map can access the row ID of the deduped object. For Ledgers, this allows us to also reuse the corresponding Ledger entries.

The original reference is kept in the map, too, since it encodes additional information about the reference besides just the row id.

An alternative considered was changing the type to string | {id: string, reference: number} but this results in additional type checks whenever the map is accessed, and also means the map is no longer monomorphic.

Comments Threads Pending Resolution

Resolved Comment Threads

eps1lon reviewed on September 11, 2026