[Flight] Preserve leading `U+FEFF` in text rows #37625

Open
unstubbable opened 4:49am on September 14, 2026 wants to merge 123 Ξ” into facebook/react main from
hl/bom-fix

Pull Request Overview

  • Opened on September 14, 2026
  • Status Open
  • Commit count 1 with first commit September 14, 2026

Total Delta

123 Total Diff Delta

Open Days

Open 5 weekdays

Test Delta

0 Diff Delta in Test Files
Breakdown by Phase

How long has this pull request spent in each phase of its lifecycle?

Fraction of total time Business days Phase
 
0.0 days Authoring 1 commit before pull request opened for review
 
0.0 days Awaiting first review
 
4.8 days Revising work with 0 commits in response to 1 review that left 3 comments

Total time for pull request still awaiting merge: 4.8 business days

Author avatar

[Flight] Preserve leading `U+FEFF` in text rows

The Flight client dropped a leading U+FEFF from outlined text rows when it decoded binary input. TextDecoder consumed the character as an encoding signature, even though it was part of the serialized string. Both the Node and Web decoders now use ignoreBOM: true to preserve it.

Regression tests cover one and two leading U+FEFF characters with normal chunks and with every UTF-8 byte delivered separately. They also include an inline-string control. The global TextDecoder Flow declaration now makes fatal optional and declares ignoreBOM, matching the API.

Comments Threads Pending Resolution

Resolved Comment Threads

eps1lon reviewed on September 14, 2026