Diff Delta:
0
About 0 Diff Delta/hour
Classified as:
General
mminutoli's Description of Work
The ROCm jobs in wheel_tests_nightly_release.yml run against two ROCm variants: the pinned TheRock 10.0.0 and the moving TheRock Next (pre-release) (therock-latest). Tracking the moving one is the point on nightlies. On a release run it is noise: those legs must test the ROCm that actually ships, and a therock-latest failure there muddies a release it has no bearing on.
Technical details
- Adds a conditional
excludeentry to each of the three ROCm matrices (build-rocm-artifacts,run-pytest-rocm,run-bazel-test-rocm) dropping thetherock-latestleg on release runs. Therocm:lists themselves are unchanged. - A run counts as a release run when
github.ref_namestarts withrelease/(upstream release branches) orrocm-jaxlib-v(downstream ROCm release branches), or when theartifact-typeinput isrelease. - The prefixes are anchored deliberately to avoid matching other branches.
- Follows the existing idiom in this file β the
&&-only expression that renders the matched value on a release branch and short-circuits tofalse(a no-op exclude) otherwise, as in the TPUlibtpu-version-typeexcludes, combined with partial-object exclude against a dict-valued dimension as inrun-pytest-cuda.
Test plan
Release-mode workflow_dispatch on ROCm/jax.
Test result
| artifact-type | build legs |
| --- | --- |
| release | 10 β all TheRock 10.0.0, zero pre-release |
| default | 20 β 10 pinned + 10 pre-release |
0 total changed files
Youβve completed the full review pass
All files reviewed β nice work, champ! πͺ