Reject redundant minimum macOS dependencies #24020

Merged
p-linnane opened 8:37am on September 17, 2026 wanted to merge 210 Ξ” into homebrew/brew main from
redundant-macos-minimum

Pull Request Overview

  • Opened on September 17, 2026
  • Status Merged
  • Commit count 1 with first commit September 17, 2026

Total Delta

210 Total Diff Delta

Open Days

Open 1 weekdays

Test Delta

140 Diff Delta in Test Files
Breakdown by Phase

How long has this pull request spent in each phase of its lifecycle?

Fraction of total time Business days Phase
 
0.0 days Authoring 1 commit before pull request opened for review
 
0.0 days Awaiting first review
 
1.0 day Merge to deploy (still awaiting deployment)

Total time for pull request 0.0 business days from first commit authored to merge
Still awaiting deployment

Author avatar

Reject redundant minimum macOS dependencies

depends_on macos: :big_sur requires a release every supported macOS already meets. Homebrew/OSDependsOn now reports minimum macOS versions at or below the runtime floor and autocorrects the plain top-level form to depends_on :macos; OS-block, multi-key, tagged and commented forms get guidance instead. The floor comes from MacOSVersion::SYMBOLS and a spec pins it to HOMEBREW_MACOS_OLDEST_ALLOWED.

A bare depends_on :macos in on_arm/on_intel now means no minimum on that architecture and Cask/NoOverrides accepts it opposite a versioned block. Both cookbooks are updated.

Current taps have 14 casks and 5 formulae to clean up.



  • [x] Have you followed our Contributing guidelines?

  • [x] Have you checked for other open Pull Requests for the same change?

  • [x] Have you explained what your changes do? Performance claims (e.g. "this is faster") must include brew benchmark results.

  • [x] Have you explained why you'd like these changes included, not just what they do?

  • [ ] For bug fixes, have you given step-by-step brew commands to reproduce the bug?

  • [x] Have you written new tests (excluding integration tests)? Here's an example.

  • [x] Have you successfully run brew lgtm (style, typechecking and tests) locally?



  • [x] I did not use AI/LLM to create this PR, or I disclosed the tool/model below and reviewed its output; I did not attribute commits to AI and will answer maintainer questions and review comments myself without AI/LLM.

Claude Code (Fable 5.1) drafted the implementation and tests; I reviewed the diff, verified the new tests fail without the change and pass with it, and ran brew lgtm --online plus targeted specs.


Comments Threads Pending Resolution

MikeMcQuaid reviewed and approved this work on September 17, 2026
MikeMcQuaid left a comment

Good idea!

ljharb reviewed on September 17, 2026
ljharb left a comment

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Resolved Comment Threads

No resolved comments have been left on this PR.