We were unable to construct the commit group for this pull request: None of the pull request's commits have been successfully processed as yet.

Type `Style` options instead of `**options` #24025

Open
dduugg opened 4:02pm on September 17, 2026 wants to merge 0 commits into homebrew/brew main from
style-typed-options

Pull Request Overview

  • Opened on September 17, 2026
  • Status Open
  • Commit count 0

Total Delta

0 Total Diff Delta

Open Days

Open 1 weekdays

Test Delta

0 Diff Delta in Test Files
Breakdown by Phase

How long has this pull request spent in each phase of its lifecycle?

Data pending calculation for pull request

Author avatar

Type `Style` options instead of `**options`

Style.check_style_and_print and Style.check_style_json take **options as T.untyped and forward it blind, so a caller's mistyped keyword reaches check_style_impl as a runtime ArgumentError instead of failing brew typecheck. Give both explicit keyword arguments instead.

display_cop_names goes with the splat: it was threaded through four signatures and never read, since run_rubocop never passes --display-cop-names to RuboCop, which displays cop names by default.

brew style now states outright that --only-cops excludes no cops, rather than leaving that to run_rubocop testing except_cops before only_cops.



  • [x] Have you followed our Contributing guidelines?

  • [x] Have you checked for other open Pull Requests for the same change?

  • [x] Have you explained what your changes do? Performance claims (e.g. "this is faster") must include brew benchmark results.

  • [x] Have you explained why you'd like these changes included, not just what they do?

  • [ ] For bug fixes, have you given step-by-step brew commands to reproduce the bug?

  • [ ] Have you written new tests (excluding integration tests)? Here's an example.

  • [x] Have you successfully run brew lgtm (style, typechecking and tests) locally?



  • [x] I did not use AI/LLM to create this PR, or I disclosed the tool/model below and reviewed its output; I did not attribute commits to AI and will answer maintainer questions and review comments myself without AI/LLM.

Claude Code with Opus 5, with local review and testing.


Comments Threads Pending Resolution

MikeMcQuaid reviewed and approved this work on September 18, 2026
MikeMcQuaid left a comment

Thanks, much nicer. Self-merge when 🟒

ljharb reviewed on September 17, 2026
ljharb left a comment

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Resolved Comment Threads

No resolved comments have been left on this PR.