mltframework/shotcut
Pull Request Overview
- Opened on June 30, 2026
- Status Merged
- Commit count 5 with first commit June 30, 2026
Total Delta
Open Days
Test Delta
How long has this pull request spent in each phase of its lifecycle?
| Fraction of total time | Business days | Phase |
|---|---|---|
| N/A | -0.0 days | Issue creation to work beginning |
|
|
0.0 days | Authoring 1 commit before pull request opened for review |
|
|
0.0 days | Awaiting first review |
|
|
0.1 days | Revising work with 4 commits in response to 1 review that left 5 comments |
| Set up deploy tracking to begin tracking full PR start-to-deploy times | ||
Total time for pull request
0.1 business days
from first commit authored to merge
Deploy tracking has not been set up
Update Convert for 10-bit and HDR
This pull request introduces improved support for HDR (High Dynamic Range) workflows by making the application's transcoding and conversion logic aware of the current processing mode's HDR compatibility. The main changes ensure that lossless transcodes use a 10-bit H.264 codec when HDR-compatible processing is enabled, and that color space conversions and user prompts are more accurate for HDR content. Several utility and dialog functions have been updated to reflect this logic, and some code has been refactored for clarity.
HDR-aware transcoding and conversion:
Added
ShotcutSettings::isHdrCompatibleProcessingMode()to determine if the current processing mode supports HDR, and updated relevant dialogs and conversion logic to use this check. (src/settings.h,src/settings.cpp,src/dialogs/transcodedialog.cpp,src/transcoder.cpp,src/util.cpp,src/widgets/avformatproducerwidget.cpp) [[1]](diffhunk://#diff-c044ba02ccf7862f1e2f56436d5b92baa7bb35601791846655fb07ac253a8697R630-R635) [[2]](diffhunk://#diff-e43eb64bdd9061c058d0e50763df67fe62bf719f55bcff809d1eadda8eb67513R135) [[3]](diffhunk://#diff-07030df8aa32460a382b281c186787dad56e981576adc3064720ca348728681bL152-R158) [[4]](diffhunk://#diff-7b909efef9eee1ead1de95a6acf4b3f0ef45a27a25d59ac494e04f86dcd2f4b4R153) [[5]](diffhunk://#diff-71add9df638df1a7aa8cc927c71965c319c6cf6c9290ecb5b90436820d4e1884L856-R857)Lossless transcode mode now uses 10-bit H.264 when HDR-compatible processing is enabled, instead of Ut Video, and sets appropriate ffmpeg arguments for 10-bit output. (
src/dialogs/transcodedialog.cpp,src/transcoder.cpp) [[1]](diffhunk://#diff-07030df8aa32460a382b281c186787dad56e981576adc3064720ca348728681bL152-R158) [[2]](diffhunk://#diff-7b909efef9eee1ead1de95a6acf4b3f0ef45a27a25d59ac494e04f86dcd2f4b4L331-R361) [[3]](diffhunk://#diff-7b909efef9eee1ead1de95a6acf4b3f0ef45a27a25d59ac494e04f86dcd2f4b4R311-R316) [[4]](diffhunk://#diff-7b909efef9eee1ead1de95a6acf4b3f0ef45a27a25d59ac494e04f86dcd2f4b4L317-R334)
Color space and conversion improvements:
Updated logic for when to offer BT.709 color conversion and when to prompt users about probable HDR content, making it conditional on both the processing mode and color transfer characteristics. (
src/util.cpp,src/widgets/avformatproducerwidget.cpp) [[1]](diffhunk://#diff-449acf764318b0ca96972daf8d28a28af79ad2c3381044851f2953792fcd8eefL827-R827) [[2]](diffhunk://#diff-449acf764318b0ca96972daf8d28a28af79ad2c3381044851f2953792fcd8eefL868-R869) [[3]](diffhunk://#diff-71add9df638df1a7aa8cc927c71965c319c6cf6c9290ecb5b90436820d4e1884L856-R857)Renamed
Util::trcIsCompatibletoUtil::trcIsSdrCompatiblefor clarity and updated all references. (src/util.h,src/util.cpp) [[1]](diffhunk://#diff-40ab92941994ec9418dbb76ae46d5aef0e4cb8b034f2be2b31562bb9aca8070fL87-R87) [[2]](diffhunk://#diff-449acf764318b0ca96972daf8d28a28af79ad2c3381044851f2953792fcd8eefL815-R815)
Other improvements:
Added
-hide_bannerto ffmpeg job arguments to reduce log clutter. (src/jobs/ffmpegjob.cpp)Updated copyright years in relevant files. (
src/dialogs/transcodedialog.cpp,src/transcoder.cpp) [[1]](diffhunk://#diff-07030df8aa32460a382b281c186787dad56e981576adc3064720ca348728681bL2-R2) [[2]](diffhunk://#diff-7b909efef9eee1ead1de95a6acf4b3f0ef45a27a25d59ac494e04f86dcd2f4b4L2-R2)
This pull request introduces improved support for HDR (High Dynamic Range) workflows by making the application's transcoding and conversion logic aware of the current processing mode's HDR compatibility. The main changes ensure that lossless transcodes use a 10-bit H.264 codec when HDR-compatible processing is enabled, and that color space conversions and user prompts are more accurate for HDR content. Several utility and dialog functions have been updated to reflect this logic, and some code has been refactored for clarity.
HDR-aware transcoding and conversion:
Added
ShotcutSettings::isHdrCompatibleProcessingMode()to determine if the current processing mode supports HDR, and updated relevant dialogs and conversion logic to use this check. (src/settings.h,src/settings.cpp,src/dialogs/transcodedialog.cpp,src/transcoder.cpp,src/util.cpp,src/widgets/avformatproducerwidget.cpp) [[1]](diffhunk://#diff-c044ba02ccf7862f1e2f56436d5b92baa7bb35601791846655fb07ac253a8697R630-R635) [[2]](diffhunk://#diff-e43eb64bdd9061c058d0e50763df67fe62bf719f55bcff809d1eadda8eb67513R135) [[3]](diffhunk://#diff-07030df8aa32460a382b281c186787dad56e981576adc3064720ca348728681bL152-R158) [[4]](diffhunk://#diff-7b909efef9eee1ead1de95a6acf4b3f0ef45a27a25d59ac494e04f86dcd2f4b4R153) [[5]](diffhunk://#diff-71add9df638df1a7aa8cc927c71965c319c6cf6c9290ecb5b90436820d4e1884L856-R857)Lossless transcode mode now uses 10-bit H.264 when HDR-compatible processing is enabled, instead of Ut Video, and sets appropriate ffmpeg arguments for 10-bit output. (
src/dialogs/transcodedialog.cpp,src/transcoder.cpp) [[1]](diffhunk://#diff-07030df8aa32460a382b281c186787dad56e981576adc3064720ca348728681bL152-R158) [[2]](diffhunk://#diff-7b909efef9eee1ead1de95a6acf4b3f0ef45a27a25d59ac494e04f86dcd2f4b4L331-R361) [[3]](diffhunk://#diff-7b909efef9eee1ead1de95a6acf4b3f0ef45a27a25d59ac494e04f86dcd2f4b4R311-R316) [[4]](diffhunk://#diff-7b909efef9eee1ead1de95a6acf4b3f0ef45a27a25d59ac494e04f86dcd2f4b4L317-R334)
Color space and conversion improvements:
Updated logic for when to offer BT.709 color conversion and when to prompt users about probable HDR content, making it conditional on both the processing mode and color transfer characteristics. (
src/util.cpp,src/widgets/avformatproducerwidget.cpp) [[1]](diffhunk://#diff-449acf764318b0ca96972daf8d28a28af79ad2c3381044851f2953792fcd8eefL827-R827) [[2]](diffhunk://#diff-449acf764318b0ca96972daf8d28a28af79ad2c3381044851f2953792fcd8eefL868-R869) [[3]](diffhunk://#diff-71add9df638df1a7aa8cc927c71965c319c6cf6c9290ecb5b90436820d4e1884L856-R857)Renamed
Util::trcIsCompatibletoUtil::trcIsSdrCompatiblefor clarity and updated all references. (src/util.h,src/util.cpp) [[1]](diffhunk://#diff-40ab92941994ec9418dbb76ae46d5aef0e4cb8b034f2be2b31562bb9aca8070fL87-R87) [[2]](diffhunk://#diff-449acf764318b0ca96972daf8d28a28af79ad2c3381044851f2953792fcd8eefL815-R815)
Other improvements:
Added
-hide_bannerto ffmpeg job arguments to reduce log clutter. (src/jobs/ffmpegjob.cpp)Updated copyright years in relevant files. (
src/dialogs/transcodedialog.cpp,src/transcoder.cpp) [[1]](diffhunk://#diff-07030df8aa32460a382b281c186787dad56e981576adc3064720ca348728681bL2-R2) [[2]](diffhunk://#diff-7b909efef9eee1ead1de95a6acf4b3f0ef45a27a25d59ac494e04f86dcd2f4b4L2-R2)
Comments Threads Pending Resolution
Resolved Comment Threads
## Pull request overview
This PR updates Shotcut’s convert/transcode workflow to better support HDR by using the current processing mode to drive HDR/10‑bit decisions (codec choice, color conversion defaults, and HDR warnings).
**Changes:**
- Added `ShotcutSettings::isHdrCompatibleProcessingMode()` and applied it to conversion prompts/defaults across UI and utility code.
- Updated `Transcoder::convertProducer()` to support 10‑bit output paths (including “lossless” mode using H.264 high10) and refined frame-rate handling.
- Reduced FFmpeg log noise by adding `-hide_banner` to FFmpeg job arguments.
### Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
| ---- | ----------- |
| src/widgets/avformatproducerwidget.cpp | Default BT.709 conversion choice now depends on HDR-capable processing mode. |
| src/util.h | Renamed TRC helper to `trcIsSdrCompatible`. |
| src/util.cpp | HDR-aware conversion advice/prompting and updated TRC compatibility helper usage. |
| src/transcoder.cpp | HDR/10-bit-aware FFmpeg argument construction, codec/pix_fmt selection, and fps handling. |
| src/settings.h | Declared `isHdrCompatibleProcessingMode()`. |
| src/settings.cpp | Implemented `isHdrCompatibleProcessingMode()`. |
| src/jobs/ffmpegjob.cpp | Added `-hide_banner` to FFmpeg args. |
| src/dialogs/transcodedialog.cpp | UI label for “Lossless” now reflects HDR mode selection (Ut Video vs H.264). |
Comments suppressed due to low confidence (1)
**src/util.cpp:819**
* `trcIsSdrCompatible()` currently treats HLG (18) as SDR-compatible, but the rest of the app explicitly classifies TRC 18 (ARIB B67) as HDR. With the new HDR-aware prompting (`getConversionAdvice()`), this suppresses the “Probable HDR” warning for HLG sources in non-HDR processing modes.
```
bool Util::trcIsSdrCompatible(int trc)
{
// Transfer characteristics > SMPTE240M Probably need conversion except IEC61966-2-4 is OK
return trc <= 7 || trc == 11 || trc == 13 || trc == 14 || trc == 15 || trc == 18;
}
```
## Pull request overview
This PR updates Shotcut’s convert/transcode workflow to better support HDR by using the current processing mode to drive HDR/10‑bit decisions (codec choice, color conversion defaults, and HDR warnings).
**Changes:**
- Added `ShotcutSettings::isHdrCompatibleProcessingMode()` and applied it to conversion prompts/defaults across UI and utility code.
- Updated `Transcoder::convertProducer()` to support 10‑bit output paths (including “lossless” mode using H.264 high10) and refined frame-rate handling.
- Reduced FFmpeg log noise by adding `-hide_banner` to FFmpeg job arguments.
### Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
| ---- | ----------- |
| src/widgets/avformatproducerwidget.cpp | Default BT.709 conversion choice now depends on HDR-capable processing mode. |
| src/util.h | Renamed TRC helper to `trcIsSdrCompatible`. |
| src/util.cpp | HDR-aware conversion advice/prompting and updated TRC compatibility helper usage. |
| src/transcoder.cpp | HDR/10-bit-aware FFmpeg argument construction, codec/pix_fmt selection, and fps handling. |
| src/settings.h | Declared `isHdrCompatibleProcessingMode()`. |
| src/settings.cpp | Implemented `isHdrCompatibleProcessingMode()`. |
| src/jobs/ffmpegjob.cpp | Added `-hide_banner` to FFmpeg args. |
| src/dialogs/transcodedialog.cpp | UI label for “Lossless” now reflects HDR mode selection (Ut Video vs H.264). |
Comments suppressed due to low confidence (1)
**src/util.cpp:819**
* `trcIsSdrCompatible()` currently treats HLG (18) as SDR-compatible, but the rest of the app explicitly classifies TRC 18 (ARIB B67) as HDR. With the new HDR-aware prompting (`getConversionAdvice()`), this suppresses the “Probable HDR” warning for HLG sources in non-HDR processing modes.
```
bool Util::trcIsSdrCompatible(int trc)
{
// Transfer characteristics > SMPTE240M Probably need conversion except IEC61966-2-4 is OK
return trc <= 7 || trc == 11 || trc == 13 || trc == 14 || trc == 15 || trc == 18;
}
```