Pull Request Overview

Opened on October 10, 2026
Status Closed
Commit count 1 with first commit October 10, 2026

Total Delta

0 Total Diff Delta

Open Days

Open 17 weekdays

Test Delta

0 Diff Delta in Test Files

Breakdown by Phase

How long has this pull request spent in each phase of its lifecycle?

Fraction of total time	Business days	Phase
N/A	0 days	Issue creation to work beginning
	0 days	Authoring 1 commit before pull request opened for review
	0 days	Awaiting first review

Total time for pull request 0 business days from first commit to closed PR

Add four passing integration test classes to tests/integration-tests.txt

What this PR does / why we need it:

Adds four integration test classes to tests/integration-tests.txt: DataCiteIT, SignedUrlAuthMechanismIT, SiteMapIT and StorageSitesIT. They pass against the CI stack but were never listed, so they never ran. That's 9 more tests in CI for about 10 seconds.

See #12815 for how they were found, and for why IpGroupsIT stays out of the list even though it passes on its own.

Which issue(s) this PR closes:

Closes #12815

Special notes for your reviewer:

The only change is one line in tests/integration-tests.txt. The same change was verified in our fork, on top of #12783: run 38064623496 gave 416 integration tests run, 0 failures and 15 skipped in all three jobs (was 407 / 0 / 15).

Suggestions on how to test this:

In the integration test results of this PR's checks, confirm that the four classes ran and passed, and that the totals went from 407 to 416 with 0 failures.

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

No.

Is there a release notes update needed for this change?:

No. It only changes which existing tests run in CI.

Additional documentation:

None.

This work implements Add four passing integration test classes to tests/integration-tests.txt (open)

Overview of the Feature Request

Four integration test classes pass against the CI stack but never run, because they aren't listed in tests/integration-tests.txt:

Class	Tests	Time
`DataCiteIT`	2	~6–10s
`SignedUrlAuthMechanismIT`	1	<1s
`SiteMapIT`	1	<1s
`StorageSitesIT`	5	<1s

Adding them to the list gives 9 more tests in CI for about 10 seconds.

What kind of user is the feature intended for?

Developers.

What inspired the request?

While working on the CI pipeline in #12782 / #12783, we ran some experiments in our fork (uncch-rdmc/dataverse):

Run every *IT class without the list (uncch-rdmc/dataverse#104, run). Failsafe found the classes by name instead of reading tests/integration-tests.txt. 27 of the 80 *IT classes aren't in the list. Most were excluded for a reason: they need Testcontainers or outside services, they're @Disabled, or they fail against the CI stack. Five unlisted classes passed in all three jobs.
Add those five to the list (uncch-rdmc/dataverse#105, run). All five passed, but DataRetrieverApiIT then failed in every job. The cause is IpGroupsIT: it grants roles to an IP group covering 0.0.0.0–255.255.255.255, and its own source warns that it inflates the collection counts other tests assert. So it's correctly left out.
Add only the other four (same PR, run). Every job was green: 416 integration tests run, 0 failures, 15 skipped (was 407 / 0 / 15), and DataRetrieverApiIT passed.

What existing behavior do you want changed?

Add DataCiteIT, SignedUrlAuthMechanismIT, SiteMapIT and StorageSitesIT to tests/integration-tests.txt.

Any brand new behavior do you want to add to Dataverse?

No.

Any open or closed issues related to this feature request?

12782

Are you thinking about creating a pull request for this feature?

Yes, a pull request will follow.

Comments Threads Pending Resolution

ljharb reviewed on October 10, 2026

ljharb left a comment

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Resolved Comment Threads

No resolved comments have been left on this PR.

Add four passing integration test classes to tests/integration-tests.txt #12816