Diff Delta:
187
About 93 Diff Delta/hour
Classified as:
Bug Fix
niels9001's Description of Work
Summary of the Pull Request
Polish for the new OOBE "Welcome to PowerToys" hero animation (#50873):
-
Hover highlight: replaces the rainbow/brand-gradient stroke on tool tiles with a subtle Fluent-style hover: a faint fill plus a 1px neutral stroke on the tile edge. In high contrast it usesSystemColorHighlightwith a 2px stroke. -
Parallax top gap: the aurora dome could slide down during pointer parallax and impact shake, leaving a gap between the blue background and the top edge of the hero. The dome now extends 24px above the hero (DomeBleed), so that gap no longer appears. -
Intro streaks: the light trails that shoot out during the intro had hard, rectangular edges. They now use aCompositionMaskBrushwith a radial falloff mask, so they have soft edges and a tapered tail.
PR Checklist
- [ ] Closes: #xxx
<!-- - [ ] Closes: #yyy (add separate lines for additional resolved issues) --> - [ ] Communication: I've discussed this with core contributors already. If the work hasn't been agreed, this work might be rejected
- [ ] Tests: Added/updated and all pass
- [x] Localization: All end-user-facing strings can be localized
- [ ] Dev docs: Added/updated
- [ ] New binaries: Added on the required places
- [ ] JSON for signing for new binaries
- [ ] WXS for installer for new binaries and localization folder
- [ ] YML for CI pipeline for new test projects
- [ ] YML for signed pipeline
- [ ] Documentation updated: If checked, please file a pull request on our docs repo and link it here: #xxx
Detailed Description of the Pull Request / Additional comments
Changes are limited to src/settings-ui/Settings.UI/SettingsXAML/Controls/WelcomeHero/:
-
WelcomeHeroPalette.cs:Color[] Highlightis replaced byHighlightFill,HighlightStrokeandHighlightStrokeThicknessfor Dark, Light and HighContrast. -
WelcomeHeroScene.cs:- The highlight shape reuses the tile's glass geometry and sits beneath the icon. Ghost tiles have no highlight, and
SetHighlightedTileis null-safe. - Theme changes animate the highlight fill and stroke colors.
-
DomeBleedoffsets the dome and its center, and the intro dawn center accounts for it. - A new shared radial
_trailMaskmasks the trail gradients.CreateTrailBrushstill returns the stops so theme updates keep working.
- The highlight shape reuses the tile's glass geometry and sits beneath the icon. Ghost tiles have no highlight, and
No new strings, binaries or settings.
Validation Steps Performed
-
tools\build\build.ps1 -Platform x64 -Configuration Debuginsrc\settings-ui\Settings.UI: passed (exit code 0, empty errors log). - Manual: ran the Debug Settings build, opened Welcome to PowerToys, watched the intro streaks, hovered over the tiles, and moved the pointer to trigger the parallax. No automated tests cover this animation.
2 total changed files
Loading changes...
Loading changes...
You've reached the end of this PR review
LGTM-land is officially in view