revert(@angular/cli): import markdown files directly for command descriptions #34109

Merged
alan-agius4 opened 6:30pm on September 17, 2026 wanted to merge 29 Ξ” into angular/angular-cli 22.2.x from
revert-3d7f081-22.2.x

Pull Request Overview

  • Opened on September 17, 2026
  • Status Merged
  • Commit count 1 with first commit September 17, 2026

Total Delta

29 Total Diff Delta

Open Days

Open 2 weekdays

Test Delta

0 Diff Delta in Test Files
Breakdown by Phase

How long has this pull request spent in each phase of its lifecycle?

Fraction of total time Business days Phase
 
0.0 days Authoring 1 commit before pull request opened for review
 
0.0 days Awaiting first review
 
1.0 day Merge to deploy (still awaiting deployment)

Total time for pull request 0.0 business days from first commit authored to merge
Still awaiting deployment

Author avatar

revert(@angular/cli): import markdown files directly for command descriptions

Reverts commit 3d7f081dbc6cc0c25740bab70d49f21c7d178c3c in 22.2.x.

Comments Threads Pending Resolution

gemini-code-assist[bot] reviewed on September 17, 2026
gemini-code-assist[bot] left a comment

## Code Review

This pull request refactors how long descriptions (Markdown files) are loaded for Angular CLI commands. It removes the custom markdown loader hook and direct imports of `.md` files, replacing them with a `longDescriptionPath` property on command modules to dynamically read the files at runtime. The review feedback highlights an issue with the relative path calculation in `command-module.ts`, which omits the `@angular/cli/` prefix and resolves to `angular/cli/src/commands/...` instead, potentially breaking documentation generation tools.

packages/angular/cli/src/command-builder/command-module.ts
76
            ? {
77
                longDescriptionRelativePath: relative(
78
                  join(__dirname, '../../../../'),
85 79
          
        this.
longDescriptionPath,
80
                ).replace(/\\/g, posix.sep),

Resolved Comment Threads

No resolved comments have been left on this PR.