fix: align protocol.registerSource request handling with protocol.handle #55172

Merged
MarshallOfSound opened 11:28am on October 21, 2026 wanted to merge 108 Ξ” into electron/electron main from
claude/project-thread-w6koru

Pull Request Overview

  • Opened on October 21, 2026
  • Status Merged
  • Commit count 1 with first commit October 21, 2026

Total Delta

108 Total Diff Delta

Open Days

Open 23 weekdays

Test Delta

0 Diff Delta in Test Files
Breakdown by Phase

How long has this pull request spent in each phase of its lifecycle?

Fraction of total time Business days Phase
 
0.0 days Authoring 1 commit before pull request opened for review
 
0.0 days Awaiting first review
 
0.1 days Revising work with 0 commits in response to 1 review that left 3 comments
Set up deploy tracking to begin tracking full PR start-to-deploy times

Total time for pull request 0.1 business days from first commit authored to merge
Deploy tracking has not been set up

Author avatar

fix: align protocol.registerSource request handling with protocol.handle

Description of Change


  • Move the renderer request checks ElectronURLLoaderFactory performs into shared helpers and apply them in ProtocolSourceURLLoaderFactory as well, so a scheme served by protocol.registerSource treats renderer fetch()/XHR requests the same way a protocol.handle scheme does.

  • Add registerSource cases next to the existing protocol.handle ones in the protocol spec.

Checklist

Release Notes

Notes: Fixed protocol.registerSource schemes not applying the same fetch rules as protocol.handle schemes.

Comments Threads Pending Resolution

Resolved Comment Threads

No resolved comments have been left on this PR.