Diff Delta:
20
About 122 Diff Delta/hour
Classified as:
General
IngmarStein's Description of Work
-
LC_ALL=Cmakestarfail on archives containing non-ASCII paths becausebsdtarcannot convert those paths to an ASCII character set. This broke with https://github.com/Homebrew/brew/pull/24278. -
en_US.UTF-8keeps diagnostics in English for the out-of-space handling inunpack_strategy.rbwhile allowing UTF-8 paths
- [x] Have you followed our Contributing guidelines?
- [x] Have you checked for other open Pull Requests for the same change?
- [x] Have you explained what your changes do? Performance claims (e.g. "this is faster") must include
brew benchmarkresults. - [x] Have you explained why you'd like these changes included, not just what they do?
- [ ] For bug fixes, have you given step-by-step
brewcommands to reproduce the bug? - [x] Have you written new tests (excluding integration tests)? Here's an example.
- [x] Have you successfully run
brew lgtm(style, typechecking and tests) locally?
- [x] I did not use AI/LLM to create this PR, or I disclosed the tool/model below and reviewed its output; I did not attribute commits to AI and will answer maintainer questions and review comments myself without AI/LLM.
Github Copilot diagnosed the issue in an Actuion Run and Claude Opus 5.5 was used to validate and look at formula-side workarounds. The diff itself is trivial.
Summary by CodeRabbit
-
Bug Fixes- Improved TAR archive extraction for paths containing non-ASCII characters.
- Preserved English-language extraction diagnostics while using UTF-8 locale support.
2 total changed files
Loading changes...
Loading changes...
Youβve reached the end of the pull request
No more diffs beyond this point