cask/audit: reject new casks requiring Rosetta #24309

Merged
bevanjkay opened 5:40pm on October 20, 2026 wanted to merge 81 ฮ” into homebrew/brew main from
casks_audit_reject_rosetta

Pull Request Overview

  • Opened on October 20, 2026
  • Status Merged
  • Commit count 1 with first commit October 20, 2026

Total Delta

81 Total Diff Delta

Open Days

Open 16 weekdays

Test Delta

0 Diff Delta in Test Files
Breakdown by Phase

How long has this pull request spent in each phase of its lifecycle?

Fraction of total time Business days Phase
 
0.0 days Authoring 1 commit before pull request opened for review
 
0.0 days Awaiting first review
Set up deploy tracking to begin tracking full PR start-to-deploy times

Total time for pull request 0.0 business days from first commit authored to merge
Deploy tracking has not been set up

Author avatar

cask/audit: reject new casks requiring Rosetta


  • macOS 27 is now the latest stable release so, per docs/Acceptable-Casks.md, new casks needing Rosetta 2 are no longer acceptable. Error in audit_rosetta when a new cask's artifacts are x86_64-only.

  • Drop the pre-Big Sur guards: Big Sur is the oldest allowed macOS. The depends_on macos: guard also skipped every cask without one, as nil&.maximum_version.to_s is "", which sorts before "11".



  • [x] Have you followed our Contributing guidelines?

  • [x] Have you checked for other open Pull Requests for the same change?

  • [x] Have you explained what your changes do? Performance claims (e.g. "this is faster") must include brew benchmark results.

  • [x] Have you explained why you'd like these changes included, not just what they do?

  • [x] For bug fixes, have you given step-by-step brew commands to reproduce the bug?

  • [x] Have you written new tests (excluding integration tests)? Here's an example.

  • [x] Have you successfully run brew lgtm (style, typechecking and tests) locally?



  • [x] I did not use AI/LLM to create this PR, or I disclosed the tool/model below and reviewed its output; I did not attribute commits to AI and will answer maintainer questions and review comments myself without AI/LLM.

Claude with Opus 5.5 at High effort, with local review and testing.


Comments Threads Pending Resolution

MikeMcQuaid reviewed and approved this work on October 20, 2026
MikeMcQuaid left a comment

Thanks!

MikeMcQuaid reviewed and approved this work on October 20, 2026
MikeMcQuaid left a comment

Thanks!

coderabbitai[bot] reviewed on October 20, 2026
coderabbitai[bot] left a comment

**Actionable comments posted: 1**

---

โ„น๏ธ Review info

โš™๏ธ Run configuration

- **Configuration used**: Organization UI
- **Review profile**: CHILL
- **Plan**: Advanced
- **Run ID**: `9e1db610-904a-4918-8ec1-38667f5a67c5`

๐Ÿ“ฅ Commits

Reviewing files that changed from the base of the PR and between 3e90673e7900beb84de27f24392a939d09a87354 and a92c72076597a29d5855b3dcbeb40b2a5fc017c8.

๐Ÿ“’ Files selected for processing: 3

* `Library/Homebrew/cask/audit.rb`
* `Library/Homebrew/test/cask/audit_spec.rb`
* `docs/Acceptable-Casks.md`

**Included review availability:** This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.

Library/Homebrew/cask/audit.rb
806
    def audit_rosetta
807
      return if (url = cask.url).nil?
808
      return unless online?
809
      return unless Homebrew::SimulateSystem.simulating_or_running_on_macos?
810
      return if Homebrew::SimulateSystem.current_arch != :arm

Resolved Comment Threads

No resolved comments have been left on this PR.