Diff Delta:
276
About 44 Diff Delta/hour
Classified as:
General
bevanjkay's Description of Work
- New casks now need a
zapstanza, which contributors find the most confusing part of a cask. Prefill it by runningbrew generate-zapon an installed copy of the app. - The cask name defaults to the download's file name, e.g.
AgentIDE-0.9.11, not the app's, so unpack the download to find the app instead. Use it to fill inapp, read its appcast forlivecheckand find the installed copy. - Only scan an installed copy, so that a generic app name doesn't match unrelated files, and skip suites of apps rather than guess.
- Unpacking only helps prefill the template, so warn rather than fail when the download can't be unpacked.
- Have
brew generate-zap --namealso match the installed app's bundle identifier, which names most preference and cache files.
- [x] Have you followed our Contributing guidelines?
- [x] Have you checked for other open Pull Requests for the same change?
- [x] Have you explained what your changes do? Performance claims (e.g. "this is faster") must include
brew benchmarkresults. - [x] Have you explained why you'd like these changes included, not just what they do?
- [ ] For bug fixes, have you given step-by-step
brewcommands to reproduce the bug? - [x] Have you written new tests (excluding integration tests)? Here's an example.
- [x] Have you successfully run
brew lgtm(style, typechecking and tests) locally?
- [ ] I did not use AI/LLM to create this PR, or I disclosed the tool/model below and reviewed its output; I did not attribute commits to AI and will answer maintainer questions and review comments myself without AI/LLM.
9 total changed files
(2 files ignored)
Loading changes...
Loading changes...
Loading changes...
Loading changes...
Loading changes...
Loading changes...
Loading changes...
Review complete πͺ
No more diffs beyond this point