Diff Delta:
203
About 68 Diff Delta/hour
Classified as:
Bug Fix
ddennedy's Description of Work
See bug report https://forum.shotcut.org/t/copying-a-filter-from-a-clip-to-a-track-creates-an-empty-fake/51989
This pull request improves the handling of filter ordering and indexing in the filter management logic, particularly to ensure correct placement of user-visible and hidden filters (such as the track audio-level meter) and to fix related bugs in filter paste and model row mapping. The changes enhance both internal correctness and user interface consistency.
Filter Ordering and Placement Improvements:
- Added a new
firstPostUserFilterIndexfunction inmltcontroller.cppto accurately locate the first hidden post-user filter, ensuring that track volume filters and pasted filters are positioned correctly relative to hidden filters like the audio-level meter. Updated themoveTrackVolumeFilterToEndfunction to use this logic for more precise placement. - Updated the filter pasting logic in
copyFiltersto ensure that pasted filters are placed ahead of hidden post filters and that GPU filters are inserted at the correct destination index, preventing UI binding issues and maintaining correct filter order. - Removed redundant adjustment of filters in
pasteFilters, as this is now handled more accurately withincopyFiltersandmoveTrackVolumeFilterToEnd.
Model Row and Filter Index Mapping:
- Replaced the
userFilterCountfunction with a newuserFilterMltIndexfunction inattachedfiltersmodel.cppto correctly map model rows to MLT filter indices, skipping hidden filters and ensuring user actions target the correct filters. UpdatedmltFilterIndexto use this new logic.
2 total changed files
Loading changes...
Loading changes...
Youβve reached the end
Approve, request changes, or stare into the void (reviewer's choice) π