Add support for Premiere and Resolve proxies #1939

Merged
ddennedy opened 6:26pm on October 16, 2026 wanted to merge 338 Δ into mltframework/shotcut master from
premiere-resolve-proxies

Pull Request Overview

  • Opened on October 17, 2026
  • Status Merged
  • Commit count 1 with first commit July 21, 2026

Total Delta

338 Total Diff Delta

Open Days

Open 20 weekdays

Test Delta

0 Diff Delta in Test Files
Breakdown by Phase

How long has this pull request spent in each phase of its lifecycle?

Fraction of total time Business days Phase
 
63.7 days Authoring 1 commit before pull request opened for review
 
0.0 days Awaiting first review
Set up deploy tracking to begin tracking full PR start-to-deploy times

Total time for pull request 63.7 business days from first commit authored to merge
Deploy tracking has not been set up

Author avatar

Add support for Premiere and Resolve proxies

This pull request refactors and improves the proxy file detection and selection logic in the proxy manager. The main changes centralize and simplify how proxy files are located and chosen, prioritize Shotcut's own proxies over external ones, and add support for detecting external proxies in more folder structures.

Proxy file detection and selection improvements:


  • Added ProxyManager::hashProxyFilePath to centralize logic for finding a proxy file in the project or global proxy folder, and updated all relevant code to use this function.

  • Added ProxyManager::existingExternalProxy, which finds the first available external proxy (GoPro, DJI, or in Proxy/Proxies folders with flexible naming and extensions), and refactored code to use this function when Shotcut's own proxy is not present.

  • Refactored proxy selection to always prefer Shotcut's own proxy if available, and only fall back to external proxies if not, ensuring more consistent proxy usage.

Code cleanup and modernization:


  • Removed the now-obsolete ProxyManager::fileExists method and replaced its usage with the new centralized detection logic.

  • Improved code readability and maintainability by consolidating proxy path logic, reducing duplicate code, and updating copyright years.

These changes make proxy handling more robust and extensible, and should reduce bugs related to proxy file detection and selection.

Comments Threads Pending Resolution

ljharb reviewed on October 17, 2026
ljharb left a comment

### 🔵 Needs a closer look

External proxies with escaped query suffixes are not detected correctly.

**No open issues** 🎉

What changed in this PR

Refactors proxy detection to prioritize Shotcut proxies and add Premiere/Resolve external proxy support.

**Changes:**
- Centralizes hashed proxy lookup.
- Adds GoPro, DJI, and folder-based external proxy detection.
- Updates XML proxy handling and removes obsolete existence logic.

| File | Description |
|---|---|
| `src/​proxymanager.h` | Declares centralized proxy lookup APIs. |
| `src/​proxymanager.cpp` | Implements proxy prioritization and external detection. |
| `src/​mltxmlchecker.cpp` | Uses centralized lookup during project loading. |

Review effort: Lite

Resolved Comment Threads

No resolved comments have been left on this PR.