iqss/dataverse
Pull request #12824 quality checks
Code files and functions touched by this pull request are analyzed below.
Quality targets
How does this pull request compare to chosen code quality targets? Read more about code quality targets.
| Target name | Target value | This PR |
|---|---|---|
| Maximum Diff Delta per PR | 500 | 670 |
| Maximum comment count per PR | 10 | 0 |
| Pull request maximum business days between activity | 3 | 15 |
| Pull request maximum business days open | 5 | 16 |
Coupled files
Are there any files from this commit that are always committed alongside another file? This often suggests that there exists code coupling to potentially remove. Read more about code coupling
No file coupling detected. 🎉
Biggest files changes in pull request
| Path | View whole file | Lines removed | Lines added | Final line count |
|---|---|---|---|---|
| src/main/java/edu/harvard/iq/dataverse/pidproviders/doi/XmlMetadataTemplate.java | BeforeAfter | 60 | 147 | 1755 |
| src/test/java/edu/harvard/iq/dataverse/pidproviders/doi/datacite/XmlMetadataTemplateTest.java | BeforeAfter | 1 | 200 | 963 |
| src/main/java/edu/harvard/iq/dataverse/ExternalIdentifier.java | BeforeAfter | 0 | 20 | 84 |
| src/test/java/edu/harvard/iq/dataverse/ExternalIdentifierTest.java | BeforeAfter | 3 | 29 | 186 |
| src/main/java/edu/harvard/iq/dataverse/settings/FeatureFlags.java | BeforeAfter | 0 | 9 | 363 |
| doc/release-notes/12824-DataCIteXML-ORCID-ROR-support.md | BeforeAfter | 0 | 7 | 7 |
| doc/sphinx-guides/source/installation/config.rst | BeforeAfter | 0 | 0 | --- |
️ Biggest functions grown or shrunk by pull request
Which functions had their line count change as part of this pull request?
| Qualified function name | View whole function | Lines removed | Lines added | Final line count |
|---|---|---|---|---|
| ExternalIdentifierTest::testIsValidAuthorIdentifierOrcid | BeforeAfter | 3 | 0 | 15 |
| XmlMetadataTemplateTest::createMultipleTextField | BeforeAfter | 0 | 14 | 13 |
| XmlMetadataTemplateTest::createCompoundValue | BeforeAfter | 0 | 14 | 13 |
| XmlMetadataTemplateTest::assertContributor | BeforeAfter | 0 | 13 | 12 |
| ExternalIdentifierTest::assertSandboxOrcidBehavior | BeforeAfter | 0 | 9 | 8 |
| XmlMetadataTemplateTest::createCompoundField | BeforeAfter | 0 | 8 | 7 |
| XmlMetadataTemplateTest::assertAffiliation | BeforeAfter | 0 | 6 | 5 |
| XmlMetadataTemplateTest::assertNameOnlyContributor | BeforeAfter | 0 | 5 | 5 |
| ExternalIdentifierTest::testSandboxOrcidCanBeEnabledAsPid | BeforeAfter | 0 | 4 | 3 |
| ExternalIdentifierTest::testSandboxOrcidIsNotPidByDefault | BeforeAfter | 0 | 4 | 3 |
| ExternalIdentifierTest::restoreSandboxOrcidSetting | BeforeAfter | 0 | 3 | 2 |
| XmlMetadataTemplateTest::URL | 0 | 2 | --- |