This pull request's diff hasn't been prepared yet. Log in with GitHub to have us prepare it for review.

Loading RestoreLifecycleListener via SPI #162737

Closed
masseyke opened 4:54pm on October 20, 2026 wanted to merge 478 Ξ” into elastic/elasticsearch main from
move-RestoreLifecycleListener-to-spi

Pull Request Overview

  • Opened on October 20, 2026
  • Status Closed
  • Commit count 10 with first commit October 20, 2026

Total Delta

478 Total Diff Delta

Open Days

Open 10 weekdays

Test Delta

123 Diff Delta in Test Files
Breakdown by Phase

How long has this pull request spent in each phase of its lifecycle?

Fraction of total time Business days Phase
 
0 days Authoring 1 commit before pull request opened for review
 
0 days Awaiting first review
 
1 day Revising work with 9 commits in response to 3 reviews that left 6 comments

Total time for pull request 2 business days from first commit to closed PR

Author avatar

Loading RestoreLifecycleListener via SPI

This changes the way a RestoreLifecycleListener is loaded. Rather than coming from RepositoryPlugin (as was done in #161286), it is loaded via SPI. Since we do not yet have any implementations, this does not impact any existing code.

Comments Threads Pending Resolution

rjernst reviewed on October 20, 2026
rjernst left a comment

Thanks @masseyke . One thing I think needs fixing

Resolved Comment Threads

SandraOKeeffe reviewed and approved this work on October 22, 2026
SandraOKeeffe left a comment

LGTM

rjernst reviewed and approved this work on October 21, 2026
rjernst left a comment

LGTM

rjernst reviewed on October 20, 2026
rjernst left a comment

Thanks @masseyke . One thing I think needs fixing